From: Christoph Hellwig <hch@infradead.org>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: "Veeraiyan, Ayyappan" <ayyappan.veeraiyan@intel.com>,
Jeff Garzik <jeff@garzik.org>,
netdev@vger.kernel.org, "Kok,
Auke-jan H" <auke-jan.h.kok@intel.com>,
arjan@linux.intel.com, akpm@linux-foundation.org
Subject: Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...
Date: Mon, 2 Jul 2007 22:42:38 +0100 [thread overview]
Message-ID: <20070702214238.GA7085@infradead.org> (raw)
In-Reply-To: <20070702140958.5ea6571a@freepuppy.localdomain.hemminger.net>
On Mon, Jul 02, 2007 at 02:09:58PM -0700, Stephen Hemminger wrote:
> The patch is close to ready for 2.6.24 when this driver will need to show up.
If intel manages to fix up the reamining issues I'd rather see it appear
in 2.6.23..
> Since I know Intel will be forced to backport this to older distro's. You
> would be best to have a single receive queue version when you have to make
> it work on the older code.
But that'll require the single receiver queue version I guess. The
netdevice abuse is the only really major issue I see, although I'd of
course really like to see the driver getting rid of the bitfield abuse
aswell.
> > Since we wanted to distinguish the various MSIX vectors in
> > /proc/interrupts and since request_irq expects memory for name to be
> > allocated somewhere, I added this part of the ring struct.
>
> You only need to store the name for when you are doing request_irq, so
> it can just be a stack temporary.
Lots of drivers where the interface name is assigned after request_irq
just use an internal name, e.g. ixgbeX in the case of this driver.
next prev parent reply other threads:[~2007-07-02 21:43 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 23:44 [ANNOUNCE] new driver ixgbe for Intel(R) 10GbE PCI Express adapters Ayyappan.Veeraiyan
2007-06-12 23:44 ` [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based " Ayyappan Veeraiyan
2007-07-02 12:52 ` Jeff Garzik
2007-07-02 14:05 ` Arjan van de Ven
2007-07-02 14:25 ` Jeff Garzik
2007-07-02 14:27 ` Arjan van de Ven
2007-07-02 14:41 ` Jeff Garzik
2007-07-02 14:41 ` Arjan van de Ven
2007-07-02 15:26 ` Kok, Auke
2007-07-02 15:32 ` Jeff Garzik
2007-07-02 15:52 ` Andrew Morton
2007-07-02 16:09 ` Jeff Garzik
2007-07-02 15:54 ` Kok, Auke
2007-07-06 8:46 ` Ingo Oeser
2007-07-02 14:31 ` Arjan van de Ven
2007-07-02 19:00 ` Veeraiyan, Ayyappan
2007-07-02 19:04 ` Ayyappan Veeraiyan
2007-07-02 20:16 ` Christoph Hellwig
2007-07-02 21:09 ` Stephen Hemminger
2007-07-02 21:42 ` Christoph Hellwig [this message]
2007-07-02 22:02 ` Kok, Auke
2007-07-02 22:08 ` Jeff Garzik
2007-07-02 22:10 ` Michael Buesch
2007-07-02 22:16 ` Jeff Garzik
2007-07-02 23:57 ` Kok, Auke
2007-07-03 0:11 ` Jeff Garzik
2007-07-03 0:16 ` Inaky Perez-Gonzalez
2007-07-03 13:19 ` Jeff Garzik
2007-07-03 18:24 ` Inaky Perez-Gonzalez
2007-07-05 23:29 ` Jeff Garzik
2007-07-03 0:08 ` Veeraiyan, Ayyappan
2007-07-03 22:01 ` Ayyappan Veeraiyan
2007-07-02 22:56 ` Veeraiyan, Ayyappan
2007-07-03 12:53 ` Neil Horman
2007-07-05 12:37 ` Neil Horman
2007-07-09 14:21 ` Veeraiyan, Ayyappan
2007-07-10 0:57 ` Neil Horman
2007-06-13 23:05 ` [ANNOUNCE] new driver ixgbe for Intel(R) 10GbE " Francois Romieu
2007-06-13 23:18 ` Kok, Auke
2007-06-14 0:06 ` Ayyappan Veeraiyan
2007-06-14 20:36 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070702214238.GA7085@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=auke-jan.h.kok@intel.com \
--cc=ayyappan.veeraiyan@intel.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).