From: David Brownell <david-b@pacbell.net>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Cleanup usbnet_probe() return value handling
Date: Tue, 3 Jul 2007 21:34:13 -0700 [thread overview]
Message-ID: <200707032134.13339.david-b@pacbell.net> (raw)
In-Reply-To: <87sl86juel.fsf@p4.be.48ers.dk>
On Monday 02 July 2007, Peter Korsgaard wrote:
> usbnet_probe() handles a positive return value from the driver bind()
> function as success, but will later only setup the status handler if the
> return value was zero, leading to confusion. Patch adjusts this to accept
> positive values as success in both checks.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
... though I'd adjust comments to say "non-negative" rather
than "positive". Most folks won't say that zero is positive.
> ---
> drivers/net/usb/usbnet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.22-rc7/drivers/net/usb/usbnet.c
> ===================================================================
> --- linux-2.6.22-rc7.orig/drivers/net/usb/usbnet.c
> +++ linux-2.6.22-rc7/drivers/net/usb/usbnet.c
> @@ -1208,7 +1208,7 @@
> status = 0;
>
> }
> - if (status == 0 && dev->status)
> + if (status >= 0 && dev->status)
> status = init_status (dev, udev);
> if (status < 0)
> goto out3;
>
> --
> Bye, Peter Korsgaard
>
next prev parent reply other threads:[~2007-07-04 4:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-02 15:40 [PATCH] Cleanup usbnet_probe() return value handling Peter Korsgaard
2007-07-02 16:14 ` David Brownell
2007-07-02 22:46 ` Peter Korsgaard
2007-07-04 4:34 ` David Brownell [this message]
2007-07-10 16:42 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707032134.13339.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=jacmet@sunsite.dk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).