From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: netdev@vger.kernel.org
Subject: Re: [RFC 2/2] shrink size of scatterlist on common i386/x86-64
Date: Thu, 05 Jul 2007 17:15:35 -0700 (PDT) [thread overview]
Message-ID: <20070705.171535.105173068.davem@davemloft.net> (raw)
In-Reply-To: <20070705170051.37ff2ab8@freepuppy.localdomain.hemminger.net>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Thu, 5 Jul 2007 17:00:51 -0700
> On Thu, 05 Jul 2007 16:43:08 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
> > From: Stephen Hemminger <shemminger@linux-foundation.org>
> > Date: Thu, 05 Jul 2007 16:14:14 -0700
> >
> > > The scatterlist only needs 16 bits for length/offset because
> > > PAGE_SIZE is 4K
> > >
> > > Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
> >
> > Unfortunately I don't think this can be done, even on i386.
> >
> > It is legal to use order!=0 pages and multi-page areas in a single
> > scatterlist entry.
> >
>
> Okay, but then using SG lists makes skbuff's much bigger.
>
> fraglist scatterlist per skbuff
> 32 bit 8 20 +12 * 18 = +216!
> 64 bit 16 32 +16 * 18 = +288
>
> So never mind...
I know, this is why nobody ever really tries to tackle this.
> I'll do a fraglist to scatter list set of routines, but not sure
> if it's worth it.
It's better to add dma_map_skb() et al. interfaces to be honest.
Also even with the scatterlist idea, we'd still need to do two
map calls, one for skb->data and one for the page vector.
next prev parent reply other threads:[~2007-07-06 0:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 23:14 [RFC 0/2] Convert skb to use scatterlist Stephen Hemminger
2007-07-05 23:14 ` [RFC 1/2] skbuff: " Stephen Hemminger
2007-07-05 23:14 ` [RFC 2/2] shrink size of scatterlist on common i386/x86-64 Stephen Hemminger
2007-07-05 23:32 ` Roland Dreier
2007-07-05 23:43 ` David Miller
2007-07-06 0:00 ` Stephen Hemminger
2007-07-06 0:15 ` David Miller [this message]
2007-07-06 7:43 ` Rusty Russell
2007-07-06 8:54 ` David Miller
2007-07-06 17:14 ` Williams, Mitch A
2007-07-06 19:20 ` David Miller
2007-07-08 16:17 ` Muli Ben-Yehuda
2007-07-09 7:06 ` David Miller
2007-07-09 8:53 ` Muli Ben-Yehuda
2007-07-08 16:11 ` Muli Ben-Yehuda
2007-07-11 23:46 ` Williams, Mitch A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070705.171535.105173068.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).