From: "Rémi Denis-Courmont" <rdenis@simphalempin.com>
To: netdev@vger.kernel.org
Cc: remi.denis-courmont@nokia.com
Subject: Re: [PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code
Date: Thu, 5 Jul 2007 19:50:59 +0300 [thread overview]
Message-ID: <200707051951.03619@auguste.remlab.net> (raw)
In-Reply-To: <468D200E.1060200@trash.net>
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
Le jeudi 5 juillet 2007, vous avez écrit :
> James Chapman wrote:
> > This cleanup fell out after adding L2TP support where a new
> > encap_rcv funcptr was added to struct udp_sock. Have XFRM use the
> > new encap_rcv funcptr, which allows us to move the XFRM encap code
> > from udp.c into xfrm4_input.c.
> >
> > Make xfrm4_rcv_encap() static since it is no longer called
> > externally.
> >
> > Signed-off-by: James Chapman <jchapman@katalix.com>
> >
> > ---
> > Tested with L2TP and L2TP/IPsec.
> >
> > Update after comments from Patrick. Fix encapsulated transport mode
> > case and remove stupid file history comment change.
>
> Looks good, thanks.
By the way, couldn't encap_type be remove altogether (using two slightly
different callbacks for ESP) from udp_sock?
--
Rémi Denis-Courmont
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2007-07-05 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 16:18 [PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code James Chapman
2007-07-05 16:45 ` Patrick McHardy
2007-07-05 16:50 ` Rémi Denis-Courmont [this message]
2007-07-05 17:25 ` James Chapman
2007-07-06 7:55 ` Rémi Denis-Courmont
2007-07-06 13:31 ` Patrick McHardy
2007-07-11 6:06 ` David Miller
2007-07-06 0:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707051951.03619@auguste.remlab.net \
--to=rdenis@simphalempin.com \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).