From: David Miller <davem@davemloft.net>
To: rusty@rustcorp.com.au
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [RFC 2/2] shrink size of scatterlist on common i386/x86-64
Date: Fri, 06 Jul 2007 01:54:17 -0700 (PDT) [thread overview]
Message-ID: <20070706.015417.74747276.davem@davemloft.net> (raw)
In-Reply-To: <1183707826.6005.177.camel@localhost.localdomain>
From: Rusty Russell <rusty@rustcorp.com.au>
Date: Fri, 06 Jul 2007 17:43:46 +1000
> On Thu, 2007-07-05 at 17:15 -0700, David Miller wrote:
> > Also even with the scatterlist idea, we'd still need to do two
> > map calls, one for skb->data and one for the page vector.
>
> We could make skb->shinfo(skb)->frags[0] the first segment and deprecate
> skb->data and skb->len.
>
> OK, you can stop hitting me now...
The fly in that ointment is that referencing the backing
page of kmalloc() data is not safe currently, especially
with SLUB.
Jens Axboe ran into this while trying to implement sendfile()
via splice() several weeks ago, it's an ongoing battle that
even C. Lameter is even involved in now :-)
next prev parent reply other threads:[~2007-07-06 8:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 23:14 [RFC 0/2] Convert skb to use scatterlist Stephen Hemminger
2007-07-05 23:14 ` [RFC 1/2] skbuff: " Stephen Hemminger
2007-07-05 23:14 ` [RFC 2/2] shrink size of scatterlist on common i386/x86-64 Stephen Hemminger
2007-07-05 23:32 ` Roland Dreier
2007-07-05 23:43 ` David Miller
2007-07-06 0:00 ` Stephen Hemminger
2007-07-06 0:15 ` David Miller
2007-07-06 7:43 ` Rusty Russell
2007-07-06 8:54 ` David Miller [this message]
2007-07-06 17:14 ` Williams, Mitch A
2007-07-06 19:20 ` David Miller
2007-07-08 16:17 ` Muli Ben-Yehuda
2007-07-09 7:06 ` David Miller
2007-07-09 8:53 ` Muli Ben-Yehuda
2007-07-08 16:11 ` Muli Ben-Yehuda
2007-07-11 23:46 ` Williams, Mitch A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070706.015417.74747276.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).