netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@o2.pl>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Andi Kleen <andi@firstfloor.org>,
	Brice Goglin <Brice.Goglin@ens-lyon.org>,
	netdev@vger.kernel.org, Divy Le Ray <divy@chelsio.com>
Subject: Re: Who's allowed to set a skb destructor?
Date: Fri, 6 Jul 2007 11:08:35 +0200	[thread overview]
Message-ID: <20070706090835.GB2362@ff.dom.local> (raw)
In-Reply-To: <20070705122847.GA13368@2ka.mipt.ru>

On Thu, Jul 05, 2007 at 04:28:47PM +0400, Evgeniy Polyakov wrote:
> Hi, Jarek.
> 
> On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski (jarkao2@o2.pl) wrote:
> > I wonder if it's very unsound to think about a one way list
> > of destructors. Of course, not owners could only clean their
> > private allocations. Woudn't this save some skb clonning,
> > copying or adding new fields for private infos?
> 
> There should not be any additional allocations, since they are very
> slow, that part of mbuf is really horrible for performance - openbsd
> hackers removed additional allocation of mbuf tag in PF code during the
> last hackathon, which doubled its performance, that is why skb has only 
> one control structure and data area, which incorporates additional 
> control information, thus there is no need for multiple destructors.

I'd like to add a few words about performance-way-thinking.

Some time ago I've read mainly networking/admins lists. One of the
most often questions was: what should I choose linux or bsd? And
very often bsd was praised for better performance, but almost
always linux was advised as more universal (even by people who
said they use both).

BSDs were sometimes recommended for specific jobs like mail etc.
but usually linux better fitted the needs. Especially well linux
appeared for an internet gateway/router/firewall/antispam thing,
and the main reasons were: netfilter with additional, unofficial
patches e.g. l-7 filtering and imq. BSD was no option here.

Some time later, reading this list, I've found many people almost
hate netfilter for performance. You can imagine how l-7 adds to
this "performance". IMQ isn't even mentioned here - looks like
some dirty word (lack of programmers affects it's quality and
doesn't help linux too). But it's nothing near performance too.
I can also remember quite a lot of questions like: how can I avoid
tc/ip and do this with netfilter only?

Probably the most of the readers/writers were small or middle
networks admins (but quite often servicing hundreds or thousans
boxes too), probably not always advanced enough, but you know what,
they made 99% of interested. So, I understand something could've
changed with voip, and there are high performance linux servers
too (their admins have never heard of imq), and probably thinking
about them could pay off better, but there could be some cost
of such thinking too.

Regards,
Jarek P.

PS: in my opinion lack of linux performance wasn't even the second
most often asked question there; rather this: why my new & beautiful
linux box sometimes lockups?

  parent reply	other threads:[~2007-07-06  9:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-04  8:04 Who's allowed to set a skb destructor? Brice Goglin
2007-07-04  9:38 ` Evgeniy Polyakov
2007-07-05 10:08 ` Andi Kleen
2007-07-05 11:07   ` Divy Le Ray
2007-07-05 13:07     ` Andi Kleen
2007-07-05 12:28   ` Jarek Poplawski
2007-07-05 12:28     ` Evgeniy Polyakov
2007-07-05 13:00       ` Jarek Poplawski
2007-07-06  9:08       ` Jarek Poplawski [this message]
2007-07-06  9:44         ` Jarek Poplawski
2007-07-05 13:06     ` Andi Kleen
2007-07-05 13:51       ` Jarek Poplawski
2007-07-06  7:47       ` Jarek Poplawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070706090835.GB2362@ff.dom.local \
    --to=jarkao2@o2.pl \
    --cc=Brice.Goglin@ens-lyon.org \
    --cc=andi@firstfloor.org \
    --cc=divy@chelsio.com \
    --cc=johnpol@2ka.mipt.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).