From: Jay Cliburn <jcliburn@gmail.com>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org, csnook@redhat.com
Subject: Re: [PATCH] atl1: remove write-only var in tx handler
Date: Fri, 6 Jul 2007 10:28:19 -0500 [thread overview]
Message-ID: <20070706102819.5702f29f@osprey.hogchain.net> (raw)
In-Reply-To: <20070706150525.GD11067@localhost.sw.ru>
On Fri, 6 Jul 2007 19:05:25 +0400
Alexey Dobriyan <adobriyan@sw.ru> wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> ---
>
> drivers/net/atl1/atl1_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/drivers/net/atl1/atl1_main.c
> +++ b/drivers/net/atl1/atl1_main.c
> @@ -634,14 +634,13 @@ static void atl1_intr_tx(struct atl1_adapter
> *adapter) struct atl1_buffer *buffer_info;
> u16 sw_tpd_next_to_clean;
> u16 cmb_tpd_next_to_clean;
> - u8 update = 0;
>
> sw_tpd_next_to_clean = atomic_read(&tpd_ring->next_to_clean);
> cmb_tpd_next_to_clean =
> le16_to_cpu(adapter->cmb.cmb->tpd_cons_idx);
> while (cmb_tpd_next_to_clean != sw_tpd_next_to_clean) {
> struct tx_packet_desc *tpd;
> - update = 1;
> +
> tpd = ATL1_TPD_DESC(tpd_ring, sw_tpd_next_to_clean);
> buffer_info =
> &tpd_ring->buffer_info[sw_tpd_next_to_clean]; if (buffer_info->dma) {
>
Acked-by: Jay Cliburn <jacliburn@bellsouth.net>
next prev parent reply other threads:[~2007-07-06 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-06 15:05 [PATCH] atl1: remove write-only var in tx handler Alexey Dobriyan
2007-07-06 15:28 ` Jay Cliburn [this message]
2007-07-10 16:42 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070706102819.5702f29f@osprey.hogchain.net \
--to=jcliburn@gmail.com \
--cc=adobriyan@sw.ru \
--cc=csnook@redhat.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).