netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Tourrilhes <jt-sDzT885Ts8HQT0dZR+AlfA@public.gmane.org>
To: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Larry Finger
	<larry.finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>,
	Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan
Date: Thu, 12 Jul 2007 09:34:40 -0700	[thread overview]
Message-ID: <20070712163440.GA13445@bougret.hpl.hp.com> (raw)
In-Reply-To: <1184211018.9446.0.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>

On Wed, Jul 11, 2007 at 11:30:17PM -0400, Dan Williams wrote:
> On Tue, 2007-07-10 at 14:25 -0500, Larry Finger wrote:
> > Jean,
> > 
> > Jean Tourrilhes wrote:
> > > 	Hi,
> > > 
> > > 	SoftMAC output the channel twice in the scan output. It should
> > > display frequency and channel, but only once for each.
> > > --------------------------------------------------------
> > >           Cell 02 - Address: A2:00:04:XX:XX:XX
> > >                     ESSID:"TheESSID"
> > >                     Protocol:IEEE 802.11b
> > >                     Mode:Ad-Hoc
> > > ->                  Channel:5
> > > ->                  Frequency:2.432 GHz (Channel 5)
> > 
> > The frequency output is needed by NetworkManager, which is why I added it. At that time, I thought 
> > that some tool or other might be scanning the output looking for "Channel:", not "Channel "; 
> > therefore I left both in. If we are sure that removing the channel-only line will not break 
> > something, I'll be happy to send your patch upstream.
> 
> Should fix NM, really, to deal with either channel or frequency and
> handle each as appropriate.
> 
> Dan

	Well, I actually like forcing driver to use frequency, because
that's an absolute physical measure and contains more meaning.
	Regards,

	Jean

  parent reply	other threads:[~2007-07-12 16:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-10 18:41 [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan Jean Tourrilhes
2007-07-10 19:25 ` Larry Finger
     [not found]   ` <4693DD18.1010905-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2007-07-10 19:47     ` Jean Tourrilhes
2007-07-12  3:30     ` Dan Williams
     [not found]       ` <1184211018.9446.0.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-07-12 16:34         ` Jean Tourrilhes [this message]
     [not found]           ` <20070712163440.GA13445-yAE0UhLNZJawPNPzzlOzwdBPR1lH4CV8@public.gmane.org>
2007-07-12 16:40             ` Larry Finger
     [not found]               ` <46965977.7020807-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2007-07-12 16:49                 ` Jean Tourrilhes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070712163440.GA13445@bougret.hpl.hp.com \
    --to=jt-sdzt885ts8hqt0dzr+alfa@public.gmane.org \
    --cc=dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=larry.finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).