From: Adrian Bunk <bunk@stusta.de>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] cleanup congestion control options
Date: Sat, 14 Jul 2007 09:10:34 +0200 [thread overview]
Message-ID: <20070714071034.GG3565@stusta.de> (raw)
In-Reply-To: <20070713.235442.75191469.davem@davemloft.net>
On Fri, Jul 13, 2007 at 11:54:42PM -0700, David Miller wrote:
> From: Adrian Bunk <bunk@stusta.de>
> Date: Sat, 14 Jul 2007 06:09:54 +0200
>
> > This patch contains the following cleanups:
> > - note in the prompt if an option depends on EXPERIMENTAL
> > - remove "default n"s that didn't have any effect
> > - remove "default m"s from options under TCP_CONG_ADVANCED:
> > if you manually choose congestion control modules you should
> > know which ones you want
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> I'm not so sure about any of this, sorry Adrian, I'm
> not applying this.
What exactly are you not sure of?
- noting the experimental status in the prompt is a common convention
in the kernel
- "default n"s like here are nops serving no purpose
This leaves only the removal of the "default m"s which I thought would
be non-controversial since people seeing these options should know best
what they need.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2007-07-14 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 4:09 [2.6 patch] cleanup congestion control options Adrian Bunk
2007-07-14 4:59 ` Valdis.Kletnieks
2007-07-14 6:54 ` David Miller
2007-07-14 7:10 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070714071034.GG3565@stusta.de \
--to=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).