netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Samuel Ortiz <samuel.ortiz@solidboot.com>,
	davem@davemloft.net, eric.y.miao@gmail.com, sam@ravnborg.org,
	netdev@vger.kernel.org, irda-users@lists.sourceforge.net,
	stable@kernel.org
Subject: Re: [PATCH] [IrDA] Fix IrDA build failure
Date: Mon, 16 Jul 2007 15:05:19 +0200	[thread overview]
Message-ID: <20070716130519.GE3653@stusta.de> (raw)
In-Reply-To: <20070716121708.GA24483@2ka.mipt.ru>

On Mon, Jul 16, 2007 at 04:17:08PM +0400, Evgeniy Polyakov wrote:
> On Mon, Jul 16, 2007 at 02:07:44PM +0200, Adrian Bunk (bunk@stusta.de) wrote:
> > > What about having all of them __devinit/__devexit?
> > 
> > That would be completely wrong.
> 
> Hi Adrian.

Hi Evgeniy,

> Then why should irda have __init/__exit at first point

for code that only gets called during driver loading resp. driver 
unloading.

> - replacing that
> with appropriate 'dev' prefix I suggested.

You seem to misunderstand what the "dev" prefix is doing.

> 	Evgeniy Polyakov

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2007-07-16 13:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-16 11:17 [PATCH] [IrDA] Fix IrDA build failure Samuel Ortiz
2007-07-16 11:56 ` Evgeniy Polyakov
2007-07-16 12:07   ` Adrian Bunk
2007-07-16 12:17     ` Evgeniy Polyakov
2007-07-16 13:05       ` Adrian Bunk [this message]
2007-07-16 15:16   ` Sam Ravnborg
2007-07-16 13:00 ` [irda-users] " Samuel Ortiz
2007-07-17  5:08   ` Adrian Bunk
     [not found] ` <20070716111715.GB22757-OPs8hQ7j6VREYlHNa9+yaNBPR1lH4CV8@public.gmane.org>
2007-07-18  9:17   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070716130519.GE3653@stusta.de \
    --to=bunk@stusta.de \
    --cc=davem@davemloft.net \
    --cc=eric.y.miao@gmail.com \
    --cc=irda-users@lists.sourceforge.net \
    --cc=johnpol@2ka.mipt.ru \
    --cc=netdev@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=samuel.ortiz@solidboot.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).