From: David Miller <davem@davemloft.net>
To: Daniel.Beschorner@facton.com
Cc: kaber@trash.net, netdev@vger.kernel.org, dada1@cosmosbay.com
Subject: Re: IPSec freeze
Date: Wed, 18 Jul 2007 01:58:42 -0700 (PDT) [thread overview]
Message-ID: <20070718.015842.90122319.davem@davemloft.net> (raw)
In-Reply-To: <3C59DB883F7B0B4D8096010D45ACCD1323024F@exch.facton.local>
From: "Beschorner Daniel" <Daniel.Beschorner@facton.com>
Date: Tue, 17 Jul 2007 21:03:20 +0200
> > >>> I managed to reproduce a crash with ipcomp, will try to
> > fix it later.
> > >>>
> > >> Yes, I can confirm this.
> > >> After disabling IPComp the crashes went away.
> > >>
> > > The crash happens in xfrm_bundle_ok when walking the bundle upwards
> > > following xfrm_dst->u.next. The loop should be stopped when
> > > xfrm_dst->u.next == first (the topmost xfrm_dst), but it points to
> > > NULL instead. I'm pretty sure the attached patch is responsible,
> > > it breaks XFRM's assumption that dst->next and xfrm_dst->u.next are
> > > the same pointer and xfrm_dst now shares the next pointer with
> > > rcu_head.next in struct dst_entry.
> > >
> > > Eric, could you look into this please?
> >
> > I fixed it myself. Daniel, can you please test this patch?
>
> Many thanks Patrick!!!
> I tested it and found it working!
Thank you for testing.
next prev parent reply other threads:[~2007-07-18 8:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 6:29 IPSec freeze Beschorner Daniel
2007-07-15 15:00 ` Patrick McHardy
2007-07-16 8:27 ` Beschorner Daniel
2007-07-16 13:09 ` Beschorner Daniel
2007-07-16 13:17 ` Patrick McHardy
2007-07-16 13:26 ` Beschorner Daniel
2007-07-16 14:07 ` Patrick McHardy
2007-07-16 14:17 ` Beschorner Daniel
2007-07-16 14:58 ` Patrick McHardy
2007-07-16 14:59 ` Patrick McHardy
2007-07-16 15:18 ` Patrick McHardy
2007-07-16 15:36 ` Beschorner Daniel
2007-07-16 18:12 ` Patrick McHardy
2007-07-17 16:10 ` Patrick McHardy
2007-07-17 19:03 ` Beschorner Daniel
2007-07-17 21:45 ` Patrick McHardy
2007-07-18 12:21 ` pmtu discovery on SA Beschorner Daniel
2007-07-18 13:14 ` Patrick McHardy
2007-07-18 16:13 ` Beschorner Daniel
2007-07-18 16:27 ` Patrick McHardy
2007-07-18 16:56 ` Mika Penttilä
2007-07-18 18:27 ` Patrick McHardy
2007-07-18 18:39 ` Mika Penttilä
2007-07-18 18:41 ` Patrick McHardy
2007-07-18 18:47 ` Mika Penttilä
2007-07-19 15:51 ` Beschorner Daniel
2007-07-18 8:58 ` David Miller [this message]
2007-07-18 8:58 ` IPSec freeze David Miller
-- strict thread matches above, loose matches on Subject: below --
2007-07-16 16:49 Beschorner Daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070718.015842.90122319.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Daniel.Beschorner@facton.com \
--cc=dada1@cosmosbay.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).