netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Steven J. Hill" <sjhill@realitydiluted.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [1/8]
Date: Thu, 19 Jul 2007 09:38:52 +0100	[thread overview]
Message-ID: <20070719083852.GA2936@infradead.org> (raw)
In-Reply-To: <469EECFA.1010704@realitydiluted.com>

On Wed, Jul 18, 2007 at 11:47:54PM -0500, Steven J. Hill wrote:
> This first patch 642xx #defines to the 'include/linux/mv643xx.h' file.

I don't think register names should change based on ifefs.  Please make
sure both variants can be supported at runtime.  While mips might not
support different controllers in one binary powerpc certainly does.

      reply	other threads:[~2007-07-19  8:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-19  4:47 [PATCH] Merge GT/MV642xx Support into MV643xx Driver [1/8] Steven J. Hill
2007-07-19  8:38 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070719083852.GA2936@infradead.org \
    --to=hch@infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=sjhill@realitydiluted.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).