From: Christoph Hellwig <hch@infradead.org>
To: "Steven J. Hill" <sjhill@realitydiluted.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [4/8]
Date: Thu, 19 Jul 2007 09:39:47 +0100 [thread overview]
Message-ID: <20070719083947.GB2936@infradead.org> (raw)
In-Reply-To: <469EEE4B.2090008@realitydiluted.com>
On Wed, Jul 18, 2007 at 11:53:31PM -0500, Steven J. Hill wrote:
> Add main 642xx support to 'drivers/net/mv643xx_eth.c' file.
This is a little too much ifdef mess. Please factor per-controller type
code into helper functions, and if they're too much have separate files
for either type.
next prev parent reply other threads:[~2007-07-19 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 4:53 [PATCH] Merge GT/MV642xx Support into MV643xx Driver [4/8] Steven J. Hill
2007-07-19 8:39 ` Christoph Hellwig [this message]
2007-07-19 14:07 ` Dale Farnsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070719083947.GB2936@infradead.org \
--to=hch@infradead.org \
--cc=netdev@vger.kernel.org \
--cc=sjhill@realitydiluted.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).