From: Jens Axboe <jens.axboe@oracle.com>
To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@linux-ipv6.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
olaf.kirch@oracle.com, johnpol@2ka.mipt.ru
Subject: Re: [PATCH][RFC] network splice receive v3
Date: Thu, 19 Jul 2007 11:07:31 +0200 [thread overview]
Message-ID: <20070719090730.GD11657@kernel.dk> (raw)
In-Reply-To: <20070719.180518.79100322.yoshfuji@linux-ipv6.org>
On Thu, Jul 19 2007, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> Hello.
>
> In article <20070711091927.GQ4587@kernel.dk> (at Wed, 11 Jul 2007 11:19:27 +0200), Jens Axboe <jens.axboe@oracle.com> says:
>
> > @@ -835,6 +835,7 @@ const struct proto_ops inet_stream_ops = {
> > .recvmsg = sock_common_recvmsg,
> > .mmap = sock_no_mmap,
> > .sendpage = tcp_sendpage,
> > + .splice_read = tcp_splice_read,
> > #ifdef CONFIG_COMPAT
> > .compat_setsockopt = compat_sock_common_setsockopt,
> > .compat_getsockopt = compat_sock_common_getsockopt,
>
> Please add similar bits in net/ipv6/af_inet6.c
> unless there are any dependency on IPv4.
> (And if there are, it is not good.)
There are no specific ipv4 depedencies, it's just an oversight. So
thanks for the clue, I'll add it!
--
Jens Axboe
prev parent reply other threads:[~2007-07-19 9:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 9:19 [PATCH][RFC] network splice receive v3 Jens Axboe
2007-07-11 18:17 ` Joel Becker
2007-07-11 18:26 ` Jens Axboe
2007-07-12 17:02 ` Evgeniy Polyakov
2007-07-13 12:21 ` Jens Axboe
2007-07-19 8:44 ` Evgeniy Polyakov
2007-07-19 9:05 ` YOSHIFUJI Hideaki / 吉藤英明
2007-07-19 9:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070719090730.GD11657@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf.kirch@oracle.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).