From: "Dale Farnsworth" <dale@farnsworth.org>
To: "Steven J. Hill" <sjhill@realitydiluted.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [4/8]
Date: Thu, 19 Jul 2007 07:07:30 -0700 [thread overview]
Message-ID: <20070719140730.GC12892@xyzzy.farnsworth.org> (raw)
In-Reply-To: <469EEE4B.2090008@realitydiluted.com>
On Thu, Jul 19, 2007 at 04:53:31AM +0000, Steven J. Hill wrote:
> Add main 642xx support to 'drivers/net/mv643xx_eth.c' file.
As Christoph said, this quantity of ifdefs really hurt the
maintainability. Refactoring is needed. Also, since in arch/powerpc
we want to have a single kernel support both MV64[34]60 and GT64260
(determined at runtime) and their register sets are so different, I
think the best approach is to have a separate module for the GT64260.
Also, please follow Documentation/SubmittingPatches. Good subjects,
diffstats and "diff -p" would have been helpful in reviewing this series.
-Dale
prev parent reply other threads:[~2007-07-19 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 4:53 [PATCH] Merge GT/MV642xx Support into MV643xx Driver [4/8] Steven J. Hill
2007-07-19 8:39 ` Christoph Hellwig
2007-07-19 14:07 ` Dale Farnsworth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070719140730.GC12892@xyzzy.farnsworth.org \
--to=dale@farnsworth.org \
--cc=netdev@vger.kernel.org \
--cc=sjhill@realitydiluted.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).