Re: [PATCH]: Resurrect napi_poll patch.

[Stephen Hemminger <shemminger@linux-foundation.org>]

On Mon, 23 Jul 2007 19:06:42 +0200
Andi Kleen <andi@firstfloor.org> wrote:

> On Mon, Jul 23, 2007 at 10:58:22AM +0100, Stephen Hemminger wrote:
> > On 21 Jul 2007 15:26:00 +0200
> > Andi Kleen <andi@firstfloor.org> wrote:
> > 
> > > David Miller <davem@davemloft.net> writes:
> > > > 
> > > > Good candidates for taking advantage of multi-napi are:
> > > > 
> > > > 1) e1000
> > > > 2) ucc_geth
> > > > 3) ehea
> > > > 4) sunvnet
> > > 
> > > s2io.c
> > 
> > sky2.c could use it because of issues with dual-port that share
> > one napi for status.
> 
> Sorry, I didn't parse the sentence. Did you mean "couldn't use it" ...? 
> Also can you elaborate why it shouldn't work?

Sky2 would make a good case for decoupling because it can have:

	device0     device1
	    \            /
             napi poll

Right now both device's share the NAPI instance on device 0,
but it take some work to make sure that the core code doesn't
upset device1 when device0 is down.

Actually, dual port boards are rare, I have one but it is a PCI-E x4
board so a pain to find a system with a slot.