From: David Miller <davem@davemloft.net>
To: rusty@rustcorp.com.au
Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org,
jgarzik@pobox.com, hadi@cyberus.ca
Subject: Re: [PATCH RFX]: napi_struct V3
Date: Tue, 24 Jul 2007 21:29:51 -0700 (PDT) [thread overview]
Message-ID: <20070724.212951.70218044.davem@davemloft.net> (raw)
In-Reply-To: <1185330794.1803.452.camel@localhost.localdomain>
From: Rusty Russell <rusty@rustcorp.com.au>
Date: Wed, 25 Jul 2007 12:33:14 +1000
> Maybe by adding YA state bit? Hold on, this might get ugly...
>
> Say netif_rx_schedule_prep() sets the MORE_TODO bit (atomically instead
> of setting __LINK_STATE_RX_SCHED) if it's going to fail, and
> netif_rx_complete() returns 0 if it was set, or 1 if it's OK. Now
> callers do:
>
> reenable_interrupts();
> if (rx_pending() || !netif_rx_complete(netdev, napi))
> disable_interrupts();
This is an interesting idea, and would work, but the extra atomics
for something that 2 or 3 drivers actually need.... unless I
misunderstand your suggestion?
next prev parent reply other threads:[~2007-07-25 4:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 4:07 [PATCH RFX]: napi_struct V3 David Miller
2007-07-24 4:47 ` Rusty Russell
2007-07-24 5:47 ` David Miller
2007-07-24 6:21 ` Rusty Russell
2007-07-25 0:45 ` David Miller
2007-07-25 1:15 ` Rusty Russell
2007-07-25 1:47 ` David Miller
2007-07-25 2:33 ` Rusty Russell
2007-07-25 4:29 ` David Miller [this message]
2007-07-25 5:09 ` Rusty Russell
2007-07-25 5:12 ` David Miller
2007-07-25 5:10 ` David Miller
2007-07-24 7:12 ` Francois Romieu
2007-07-24 7:33 ` Jeff Garzik
2007-07-24 7:35 ` David Miller
2007-07-28 15:21 ` Roland Dreier
2007-07-29 5:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070724.212951.70218044.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).