From: Al Viro <viro@ftp.linux.org.uk>
To: bphilips@suse.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2][RFC] Update net core to use devres.
Date: Wed, 25 Jul 2007 00:09:22 +0100 [thread overview]
Message-ID: <20070724230922.GA27392@ftp.linux.org.uk> (raw)
In-Reply-To: <20070724225134.GV21668@ftp.linux.org.uk>
On Tue, Jul 24, 2007 at 11:51:34PM +0100, Al Viro wrote:
> On Tue, Jul 24, 2007 at 03:39:52PM -0700, bphilips@suse.de wrote:
> > * netdev_pci_remove_one() can replace simple pci device remove
> > functions
> >
> > * devm_alloc_netdev() is like alloc_netdev but allocates memory using devres.
> > alloc_netdev() can be removed once all drivers use devres.
>
> Ewwww... What the hell for? To make sure that we have struct device
> for everything, whether we need it or not? Have you actually read
> through drivers/net? I mean, _really_ read through it, looking for
> ugly cases...
>
> I've done just that several times and I'm sorry, but I would classify
> that project as hopeless. It's way, _way_ more diverse than SATA...
Actually, it's even worse - net_device itself simply *cannot* be
dealt with that way. Its lifetime can indefinitely exceed that
of underlying e.g. PCI device.
next prev parent reply other threads:[~2007-07-24 23:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 22:39 [PATCH 0/2][RFC] Update network drivers to use devres bphilips
2007-07-24 22:39 ` [PATCH 1/2][RFC] Update net core " bphilips
2007-07-24 22:51 ` Al Viro
2007-07-24 23:09 ` Al Viro [this message]
2007-07-24 23:26 ` Brandon Philips
2007-07-24 23:30 ` Al Viro
2007-07-25 1:23 ` Al Viro
2007-07-24 23:42 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070724230922.GA27392@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=bphilips@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).