From: David Miller <davem@davemloft.net>
To: jeff@garzik.org
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org,
hadi@cyberus.ca, rusty@rustcorp.com.au
Subject: Re: [PATCH RFC]: napi_struct V4
Date: Wed, 25 Jul 2007 19:02:45 -0700 (PDT) [thread overview]
Message-ID: <20070725.190245.68070169.davem@davemloft.net> (raw)
In-Reply-To: <46A8003F.1050208@garzik.org>
From: Jeff Garzik <jeff@garzik.org>
Date: Wed, 25 Jul 2007 22:00:31 -0400
> David Miller wrote:
> > From: Jeff Garzik <jgarzik@pobox.com>
> > Date: Wed, 25 Jul 2007 21:55:08 -0400
> >
> >> I don't see any logic to your request, only added overhead for no reason.
> >
> > There may be some flawed logic in what Stephen stated, but
> > the change really is needed.
> >
> > It must be atomic to execute the:
> >
> > enable_interrupts();
> > netif_rx_complete();
> >
> > sequence wrt. the same code path in the interrupt handler.
>
> Sure. And how did the existing code fail to achieve that?
The interrupt handler can run on another cpu in betwen those two
statements, running the NAPI test-and-do-something operations in
parallel with the netif_rx_complete() which causes problems as Rusty
and I discussed yesterday.
next prev parent reply other threads:[~2007-07-26 2:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 8:31 [PATCH RFC]: napi_struct V4 David Miller
2007-07-25 8:56 ` Stephen Hemminger
2007-07-26 0:37 ` David Miller
2007-07-26 1:55 ` Jeff Garzik
2007-07-26 1:56 ` David Miller
2007-07-26 2:00 ` Jeff Garzik
2007-07-26 2:02 ` David Miller [this message]
2007-07-28 18:08 ` Jeff Garzik
2007-07-29 5:33 ` David Miller
2007-07-25 12:01 ` jamal
2007-07-26 4:09 ` David Miller
2007-07-26 6:33 ` Michael Chan
2007-07-26 6:38 ` David Miller
2007-07-26 7:05 ` Michael Chan
2007-07-26 7:15 ` David Miller
2007-07-26 21:38 ` Michael Chan
2007-07-31 0:25 ` David Miller
2007-07-26 6:39 ` Michael Chan
2007-07-26 6:43 ` David Miller
2007-07-28 15:27 ` Roland Dreier
2007-07-29 5:32 ` David Miller
2007-07-30 15:04 ` Roland Dreier
2007-07-30 22:48 ` David Miller
2007-07-31 2:01 ` Roland Dreier
2007-07-31 2:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070725.190245.68070169.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).