From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org,
jgarzik@pobox.com, hadi@cyberus.ca, rusty@rustcorp.com.au
Subject: Re: [PATCH RFC]: napi_struct V4
Date: Wed, 25 Jul 2007 23:43:42 -0700 (PDT) [thread overview]
Message-ID: <20070725.234342.63127611.davem@davemloft.net> (raw)
In-Reply-To: <1551EAE59135BE47B544934E30FC4FC002AAB9F7@nt-irva-0751.brcm.ad.broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 25 Jul 2007 23:39:18 -0700
> David Miller wrote:
>
> > As a result there is no more messing around with fake NAPI polls and
> > all that other crap, instead ->poll_controller() merely has to try to
> > process TX queue acks to free up space and wake up the transmit
> > queue(s) of the device.
> >
>
> I think we also need to take care of link change interrupts as well.
Since netpoll is best-effort, we can elide that I think.
The more requirements you put into this ->poll_controller()
handler, the more complicated it gets.
Furthermore, this should work out. If the link is down, the top level
poll loop will timeout waiting for the TX queue to open up, which will
kick the netpoll processing into a work queue, the link handling will
be allowed to occur meanwhile.
next prev parent reply other threads:[~2007-07-26 6:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 8:31 [PATCH RFC]: napi_struct V4 David Miller
2007-07-25 8:56 ` Stephen Hemminger
2007-07-26 0:37 ` David Miller
2007-07-26 1:55 ` Jeff Garzik
2007-07-26 1:56 ` David Miller
2007-07-26 2:00 ` Jeff Garzik
2007-07-26 2:02 ` David Miller
2007-07-28 18:08 ` Jeff Garzik
2007-07-29 5:33 ` David Miller
2007-07-25 12:01 ` jamal
2007-07-26 4:09 ` David Miller
2007-07-26 6:33 ` Michael Chan
2007-07-26 6:38 ` David Miller
2007-07-26 7:05 ` Michael Chan
2007-07-26 7:15 ` David Miller
2007-07-26 21:38 ` Michael Chan
2007-07-31 0:25 ` David Miller
2007-07-26 6:39 ` Michael Chan
2007-07-26 6:43 ` David Miller [this message]
2007-07-28 15:27 ` Roland Dreier
2007-07-29 5:32 ` David Miller
2007-07-30 15:04 ` Roland Dreier
2007-07-30 22:48 ` David Miller
2007-07-31 2:01 ` Roland Dreier
2007-07-31 2:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070725.234342.63127611.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=jgarzik@pobox.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).