public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: shemminger@oldman.hamilton.local
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH 0/3] TCP timestamp hardening (update)
Date: Wed, 25 Jul 2007 11:44:35 +0100	[thread overview]
Message-ID: <20070725104434.998037763@oldman.hamilton.local> (raw)

These patches deal with issues brought up by Gavin McCullagh
about reactions of Cubic and HTCP to hostile receivers that return
bogus timestamp options. If the receiver crafts a timestamp that is
larger than the original, then some of the congestion control algorithms
maybe come unfair.

The solution in these patches is to only use local values to measure
RTT for congestion control.  The timestamp is still used as described
in RFC's to measure RTT used for retransmit timer.

Thank you to Sangtae Ha for testing, these, see:
  http://netsrv.csc.ncsu.edu/net-2.6.22/stephen_lowres/
He also found some pre-existing problems with TCP-LP that might
be related to NAPI on the receiver.

This should go into 2.6.23. But not into the stable kernel
since the risk of causing regression is greater than the possible
risk exposure.

-- 


             reply	other threads:[~2007-07-25 11:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-25 10:44 shemminger [this message]
2007-07-25 10:44 ` [PATCH 1/3] TCP: congestion control API pass RTT in microseconds shemminger
2007-07-25 10:44 ` [PATCH 2/3] TCP: cubic - eliminate use of receive time stamp shemminger
2007-07-25 10:44 ` [PATCH 3/3] TCP: htcp - use measured rtt shemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070725104434.998037763@oldman.hamilton.local \
    --to=shemminger@oldman.hamilton.local \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox