From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org, allan.stephens@windriver.com,
per.liden@ericsson.com, jon.maloy@ericsson.com,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH] TIPC: fix tipc_link_create error handling
Date: Thu, 26 Jul 2007 00:05:21 -0700 (PDT) [thread overview]
Message-ID: <20070726.000521.88703127.davem@davemloft.net> (raw)
In-Reply-To: <20070724220256.GC8732@Chamillionaire.breakpoint.cc>
From: Florian Westphal <fw@strlen.de>
Date: Wed, 25 Jul 2007 00:02:56 +0200
> if printbuf allocation or tipc_node_attach_link() fails, invalid
> references to the link are left in the associated node and bearer
> structures.
> Fix by allocating printbuf early and moving timer initialization
> and the addition of the new link to the b_ptr->links list after
> tipc_node_attach_link() succeeded.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Looks good Florian, patch applied, thanks.
prev parent reply other threads:[~2007-07-26 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 18:34 [PATCH] TIPC: fix tipc_link_create error handling Florian Westphal
2007-07-23 19:49 ` Stephens, Allan
2007-07-24 22:02 ` Florian Westphal
2007-07-26 7:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070726.000521.88703127.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=allan.stephens@windriver.com \
--cc=fw@strlen.de \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=per.liden@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).