netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rémi Denis-Courmont" <rdenis@simphalempin.com>
To: Simon Arlott <simon@fire.lp0.eu>
Cc: Dave Johnson <djohnson+linux-kernel@sw.starentnetworks.com>,
	netdev@vger.kernel.org, davem@davemloft.net,
	linux-kernel@vger.kernel.org,
	lksctp-developers@lists.sourceforge.net,
	Srinivas Akkipeddi <sakkiped@starentnetworks.com>
Subject: Re: [PATCH] IPv6: ipv6_addr_type() doesn't know about RFC4193 addresses
Date: Thu, 26 Jul 2007 21:06:48 +0300	[thread overview]
Message-ID: <200707262106.49131.rdenis@simphalempin.com> (raw)
In-Reply-To: <46A8D837.1030400@simon.arlott.org.uk>

On Thursday 26 July 2007 20:21:59 Simon Arlott wrote:
> On 26/07/07 00:49, Dave Johnson wrote:
> > ipv6_addr_type() doesn't check for 'Unique Local IPv6 Unicast
> > Addresses' (RFC4193) and returns IPV6_ADDR_RESERVED for that range.
> >
> > +	if ((st & htonl(0xFE000000)) == htonl(0xFC000000))
> > +		return (IPV6_ADDR_UNICAST |
> > +			IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_GLOBAL));			/* RFC 4193 */
>
> But ULA's scope isn't global, shouldn't it be IPV6_ADDR_SCOPE_ORGLOCAL ?

Yes it is - global.

-- 
Rémi Denis-Courmont

  parent reply	other threads:[~2007-07-26 18:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-25 23:49 [PATCH] IPv6: ipv6_addr_type() doesn't know about RFC4193 addresses Dave Johnson
2007-07-26  0:12 ` David Miller
2007-07-26  1:11   ` Dave Johnson
2007-07-26 17:59     ` [Lksctp-developers] " Vlad Yasevich
2007-07-26 18:37   ` YOSHIFUJI Hideaki / 吉藤英明
2007-07-26 17:21 ` Simon Arlott
2007-07-26 18:00   ` Dave Johnson
2007-07-26 18:10     ` [Lksctp-developers] " Vlad Yasevich
2007-07-26 18:06   ` Rémi Denis-Courmont [this message]
2007-07-26 18:34 ` YOSHIFUJI Hideaki / 吉藤英明
2007-07-31  0:21   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200707262106.49131.rdenis@simphalempin.com \
    --to=rdenis@simphalempin.com \
    --cc=davem@davemloft.net \
    --cc=djohnson+linux-kernel@sw.starentnetworks.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lksctp-developers@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=sakkiped@starentnetworks.com \
    --cc=simon@fire.lp0.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).