From: Michael Buesch <mb@bu3sch.de>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
bcm43xx-dev@lists.berlios.de, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org,
Gary Zambrano <zambrano@broadcom.com>
Subject: Re: [PATCH] Merge the Sonics Silicon Backplane subsystem
Date: Fri, 27 Jul 2007 21:39:45 +0200 [thread overview]
Message-ID: <200707272139.45629.mb@bu3sch.de> (raw)
In-Reply-To: <20070727192120.GB7572@tuxdriver.com>
On Friday 27 July 2007 21:21:20 John W. Linville wrote:
> On Fri, Jul 27, 2007 at 06:57:20PM +0200, Michael Buesch wrote:
> > The Sonics Silicon Backplane is a mini-bus used on
> > various Broadcom chips and embedded devices.
> > Devices using the SSB include b44, bcm43xx and various
> > Broadcom based wireless routers.
> > A b44 and bcm43xx port and a SSB based OHCI driver is available.
> >
> > Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> At first glance it looks like there might be some tab/space issues
> in some of the #define blocks toward the end of the patch, although
> those might be intentional.
They are intentional. It's something like this:
#define SSB_REGISTER_XX 0xF88
#define SSB_VALUE_FOR_REGISTER_XX 0x0001
#define SSB_MASK_FOR_REGISTER_XX 0xFF00
#define SSB_REGISTER_YY 0xF99
...
> Aside from whatever other style issues that might be identified, I'll
> state that this code has been carried in wireless-dev for months and
> thereby also spent a lot of time in -mm as well as Fedora (rawhide
> and F-7). The code has proven to be reasonably stable and reliable.
And it's in the OpenWRT trunk since quite some time.
--
Greetings Michael.
next prev parent reply other threads:[~2007-07-27 19:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-27 16:57 [PATCH] Merge the Sonics Silicon Backplane subsystem Michael Buesch
[not found] ` <200707271857.24162.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-07-27 19:03 ` Andrew Morton
[not found] ` <20070727120318.54d18cfc.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2007-07-27 19:30 ` Michael Buesch
[not found] ` <200707272130.48973.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-07-27 19:38 ` Andrew Morton
[not found] ` <20070727123853.d16e875c.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2007-07-27 19:43 ` Michael Buesch
[not found] ` <200707272143.59551.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2007-07-27 20:12 ` Andrew Morton
[not found] ` <20070727131249.74330a3d.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2007-07-27 20:28 ` Michael Buesch
2007-07-29 4:45 ` Dmitry Torokhov
2007-07-27 19:21 ` John W. Linville
2007-07-27 19:39 ` Michael Buesch [this message]
2007-08-02 13:58 ` Geert Uytterhoeven
2007-08-02 14:24 ` Michael Buesch
2007-08-02 16:12 ` Geert Uytterhoeven
2007-08-02 16:18 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707272139.45629.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@osdl.org \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).