[PATCH 4/4] l2cap: don't mangle cmd.len

[PATCH 4/4] l2cap: don't mangle cmd.len

[Al Viro]

Since nobody uses it after we convert it to host-endian,
no need to do that at all.  At that point l2cap is endian-clean.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 net/bluetooth/l2cap.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
index 03309d2..c4e4ce4 100644
--- a/net/bluetooth/l2cap.c
+++ b/net/bluetooth/l2cap.c
@@ -1754,7 +1754,6 @@ static inline void l2cap_sig_channel(struct l2cap_conn *conn, struct sk_buff *sk
 		len  -= L2CAP_CMD_HDR_SIZE;
 
 		cmd_len = le16_to_cpu(cmd.len);
-		cmd.len = cmd_len;
 
 		BT_DBG("code 0x%2.2x len %d id 0x%2.2x", cmd.code, cmd_len, cmd.ident);
 
-- 
1.5.3.GIT

Re: [PATCH 4/4] l2cap: don't mangle cmd.len

[Marcel Holtmann]

Hi Al,

> Since nobody uses it after we convert it to host-endian,
> no need to do that at all.  At that point l2cap is endian-clean.
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel

Re: [PATCH 4/4] l2cap: don't mangle cmd.len

[David Miller]

From: Marcel Holtmann <marcel@holtmann.org>
Date: Fri, 27 Jul 2007 16:41:26 +0200

> > Since nobody uses it after we convert it to host-endian,
> > no need to do that at all.  At that point l2cap is endian-clean.
> > 
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Also applied, thanks a lot.