From: Adrian Bunk <bunk@stusta.de>
To: Jamal Hadi Salim <hadi@cyberus.ca>,
Robert Olsson <robert.olsson@its.uu.se>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [2.6 patch] make pktgen.c:get_ipsec_sa() static and non-inline
Date: Sun, 29 Jul 2007 16:58:40 +0200 [thread overview]
Message-ID: <20070729145840.GY16817@stusta.de> (raw)
Non-static inline code usually doesn't makes sense.
In this case making is static and non-inline is the correct solution.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
--- linux-2.6.23-rc1-mm1/net/core/pktgen.c.old 2007-07-26 20:12:01.000000000 +0200
+++ linux-2.6.23-rc1-mm1/net/core/pktgen.c 2007-07-26 20:12:13.000000000 +0200
@@ -2156,8 +2156,7 @@
/* If there was already an IPSEC SA, we keep it as is, else
* we go look for it ...
*/
-inline
-void get_ipsec_sa(struct pktgen_dev *pkt_dev, int flow)
+static void get_ipsec_sa(struct pktgen_dev *pkt_dev, int flow)
{
struct xfrm_state *x = pkt_dev->flows[flow].x;
if (!x) {
next reply other threads:[~2007-07-29 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 14:58 Adrian Bunk [this message]
2007-07-31 1:04 ` [2.6 patch] make pktgen.c:get_ipsec_sa() static and non-inline David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070729145840.GY16817@stusta.de \
--to=bunk@stusta.de \
--cc=hadi@cyberus.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robert.olsson@its.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox