From: Michael Buesch <mb@bu3sch.de>
To: Satyam Sharma <satyam@infradead.org>
Cc: Domen Puncer <domen@coderock.org>,
Jesper Juhl <jesper.juhl@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Steven Hirsch <shirsch@adelphia.net>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] sb1000: prevent a potential NULL pointer dereference in sb1000_dev_ioctl()
Date: Sun, 29 Jul 2007 20:48:20 +0200 [thread overview]
Message-ID: <200707292048.20531.mb@bu3sch.de> (raw)
In-Reply-To: <alpine.LFD.0.999.0707300003440.30928@enigma.security.iitk.ac.in>
On Sunday 29 July 2007 20:34:46 Satyam Sharma wrote:
> (2) !(dev->flags & IFF_UP) is bogus because the functions of this ioctl
> can (and should) be allowed even when the interface is not up and running.
Are you _sure_? This function does poke with the device hardware.
It might return crap or even machinecheck when not initialized.
Hardware is probably powered down, if not IFF_UP. (I don't know if that's
the case here, though).
> drivers/net/sb1000.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/sb1000.c b/drivers/net/sb1000.c
> index 1de3eec..f60fe98 100644
> --- a/drivers/net/sb1000.c
> +++ b/drivers/net/sb1000.c
> @@ -993,9 +993,6 @@ static int sb1000_dev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
> unsigned int stats[5];
> struct sb1000_private *lp = netdev_priv(dev);
>
> - if (!(dev && dev->flags & IFF_UP))
> - return -ENODEV;
> -
--
Greetings Michael.
next prev parent reply other threads:[~2007-07-29 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200707290002.42722.jesper.juhl@gmail.com>
2007-07-29 4:37 ` [PATCH] sb1000: prevent a potential NULL pointer dereference in sb1000_dev_ioctl() Domen Puncer
2007-07-29 6:04 ` Satyam Sharma
2007-07-29 18:34 ` Satyam Sharma
2007-07-29 18:48 ` Michael Buesch [this message]
2007-07-29 19:09 ` Satyam Sharma
2007-07-29 20:49 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707292048.20531.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=davem@davemloft.net \
--cc=domen@coderock.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=satyam@infradead.org \
--cc=shirsch@adelphia.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).