From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6 1/2] [TCP]: Fix ratehalving with bidirectional flows
Date: Mon, 30 Jul 2007 19:49:46 -0700 (PDT) [thread overview]
Message-ID: <20070730.194946.08653937.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0707302017290.8788@kivilampi-30.cs.helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Mon, 30 Jul 2007 20:18:45 +0300 (EEST)
> Actually, the ratehalving seems to work too well, as cwnd is
> reduced on every second ACK even though the packets in flight
> remains unchanged. Recoveries in a bidirectional flows suffer
> quite badly because of this, both NewReno and SACK are affected.
>
> After this patch, rate halving is performed for ACK only if
> packets in flight was supposedly changed too.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
This fix looks great, and I see no potential problems with
Reno after doing a bit of auditing.
Applied and I'll push to -stable too.
next prev parent reply other threads:[~2007-07-31 2:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 17:16 [PATCH net-2.6 0/2] [TCP]: Fix bidirectional brokeness Ilpo Järvinen
2007-07-30 17:18 ` [PATCH net-2.6 1/2] [TCP]: Fix ratehalving with bidirectional flows Ilpo Järvinen
2007-07-31 2:49 ` David Miller [this message]
2007-07-31 4:59 ` Ilpo Järvinen
2007-07-31 5:21 ` David Miller
2007-07-31 9:51 ` Stephen Hemminger
2007-07-31 9:58 ` David Miller
2007-07-31 13:37 ` Stephen Hemminger
2007-07-31 15:59 ` Ilpo Järvinen
2007-07-30 17:19 ` [PATCH net-2.6 2/2] [TCP]: Bidir flow must not disregard SACK blocks for lost marking Ilpo Järvinen
2007-07-31 2:53 ` David Miller
2007-07-31 5:33 ` Ilpo Järvinen
2007-07-31 2:54 ` [PATCH net-2.6 0/2] [TCP]: Fix bidirectional brokeness David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070730.194946.08653937.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).