From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6 1/2] [TCP]: Fix ratehalving with bidirectional flows
Date: Mon, 30 Jul 2007 22:21:12 -0700 (PDT) [thread overview]
Message-ID: <20070730.222112.41634340.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0707310751260.15079@kivilampi-30.cs.helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Tue, 31 Jul 2007 07:59:10 +0300 (EEST)
> I think it's probably good to add tp->snd_una != prior_snd_una
> check there too... It's not going to make a large difference,
> mostly just to be conservative when skb collapse stuff got done
> (and maybe to annoy cheaters too though I couldn't at this point
> figure out how they could abuse it)...
>
> ...I think I can come up with that on Wednesday, so please hold
> stable push until that.
It'll definitely need to wait at least a day as I cannot even make TCP
or UDP connections out from my machine with the current net-2.6 tree,
and this is what I'm debugging at the moment.
I'm hoping that it's just something stupid like the make not
rebuilding everything necessary after I changed the __u16's into
__u32's in skb_frag_t.
next prev parent reply other threads:[~2007-07-31 5:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 17:16 [PATCH net-2.6 0/2] [TCP]: Fix bidirectional brokeness Ilpo Järvinen
2007-07-30 17:18 ` [PATCH net-2.6 1/2] [TCP]: Fix ratehalving with bidirectional flows Ilpo Järvinen
2007-07-31 2:49 ` David Miller
2007-07-31 4:59 ` Ilpo Järvinen
2007-07-31 5:21 ` David Miller [this message]
2007-07-31 9:51 ` Stephen Hemminger
2007-07-31 9:58 ` David Miller
2007-07-31 13:37 ` Stephen Hemminger
2007-07-31 15:59 ` Ilpo Järvinen
2007-07-30 17:19 ` [PATCH net-2.6 2/2] [TCP]: Bidir flow must not disregard SACK blocks for lost marking Ilpo Järvinen
2007-07-31 2:53 ` David Miller
2007-07-31 5:33 ` Ilpo Järvinen
2007-07-31 2:54 ` [PATCH net-2.6 0/2] [TCP]: Fix bidirectional brokeness David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070730.222112.41634340.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).