netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Satyam Sharma <satyam@infradead.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Keiichi Kii <k-keiichi@bx.jp.nec.com>,
	Netdev <netdev@vger.kernel.org>,
	Joel Becker <joel.becker@oracle.com>,
	Matt Mackall <mpm@selenic.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Miller <davem@davemloft.net>
Subject: [PATCH v3 -mm 2/9] netconsole: Remove bogus check
Date: Mon, 30 Jul 2007 08:18:01 +0530	[thread overview]
Message-ID: <20070730024801.10828.79291.sendpatchset@enigma.security.iitk.ac.in> (raw)
In-Reply-To: <20070730024741.10828.48209.sendpatchset@enigma.security.iitk.ac.in>

From: Satyam Sharma <satyam@infradead.org>

[2/9] netconsole: Remove bogus check

The (!np.dev) check in write_msg() is bogus (always false), because:
np.dev is set by netpoll_setup(), which is called by init_netconsole()
before register_console(), so write_msg() cannot be triggered unless
netpoll_setup() successfully set np.dev. Also np.dev cannot go away
from under us, because netpoll_setup() grabs us reference on it. So
let's remove the bogus check.

Signed-off-by: Satyam Sharma <satyam@infradead.org>
Acked-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
Acked-by: Matt Mackall <mpm@selenic.com>

---

 drivers/net/netconsole.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index f1c2a2d..2c2aef1 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -67,9 +67,6 @@ static void write_msg(struct console *con, const char *msg, unsigned int len)
 	int frag, left;
 	unsigned long flags;
 
-	if (!np.dev)
-		return;
-
 	local_irq_save(flags);
 
 	for (left = len; left;) {

  parent reply	other threads:[~2007-07-30  2:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-30  2:47 [PATCH v3 -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability Satyam Sharma
2007-07-30  2:47 ` [PATCH v3 -mm 1/9] netconsole: Cleanups, codingstyle, prettyfication Satyam Sharma
2007-07-30  2:48 ` Satyam Sharma [this message]
2007-07-30  2:48 ` [PATCH v3 -mm 3/9] netconsole: Simplify boot/module option setup logic Satyam Sharma
2007-07-30  2:48 ` [PATCH v3 -mm 4/9] netconsole: Use netif_running() in write_msg() Satyam Sharma
2007-07-30  2:48 ` [PATCH v3 -mm 5/9] netconsole: Add some useful tips to documentation Satyam Sharma
2007-07-30  2:48 ` [PATCH v3 -mm 6/9] netconsole: Introduce netconsole_target Satyam Sharma
2007-07-30  2:48 ` [PATCH v3 -mm 7/9] netconsole: Introduce netconsole_netdev_notifier Satyam Sharma
2007-07-30  2:49 ` [PATCH v3 -mm 8/9] netconsole: Support multiple logging targets Satyam Sharma
2007-07-30  2:49 ` [PATCH v3 -mm 9/9] netconsole: Support dynamic reconfiguration using configfs Satyam Sharma
2007-07-31  0:13   ` Andrew Morton
2007-07-31  0:40     ` Satyam Sharma
2007-07-31  0:12 ` [PATCH v3 -mm 0/9] netconsole: Multiple targets and dynamic reconfigurability Andrew Morton
2007-07-31  0:33   ` Satyam Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070730024801.10828.79291.sendpatchset@enigma.security.iitk.ac.in \
    --to=satyam@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=joel.becker@oracle.com \
    --cc=k-keiichi@bx.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).