From mboxrd@z Thu Jan 1 00:00:00 1970 From: Satyam Sharma Subject: [PATCH v3 -mm 2/9] netconsole: Remove bogus check Date: Mon, 30 Jul 2007 08:18:01 +0530 Message-ID: <20070730024801.10828.79291.sendpatchset@enigma.security.iitk.ac.in> References: <20070730024741.10828.48209.sendpatchset@enigma.security.iitk.ac.in> Cc: Keiichi Kii , Netdev , Joel Becker , Matt Mackall , Andrew Morton , David Miller To: Linux Kernel Mailing List Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:43467 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966004AbXG3Cfl (ORCPT ); Sun, 29 Jul 2007 22:35:41 -0400 In-Reply-To: <20070730024741.10828.48209.sendpatchset@enigma.security.iitk.ac.in> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Satyam Sharma [2/9] netconsole: Remove bogus check The (!np.dev) check in write_msg() is bogus (always false), because: np.dev is set by netpoll_setup(), which is called by init_netconsole() before register_console(), so write_msg() cannot be triggered unless netpoll_setup() successfully set np.dev. Also np.dev cannot go away from under us, because netpoll_setup() grabs us reference on it. So let's remove the bogus check. Signed-off-by: Satyam Sharma Acked-by: Keiichi Kii Acked-by: Matt Mackall --- drivers/net/netconsole.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index f1c2a2d..2c2aef1 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -67,9 +67,6 @@ static void write_msg(struct console *con, const char *msg, unsigned int len) int frag, left; unsigned long flags; - if (!np.dev) - return; - local_irq_save(flags); for (left = len; left;) {