From: Flavio Leitner <fleitner@redhat.com>
To: David L Stevens <dlstevens@us.ibm.com>
Cc: davem@davemloft.net, acme@ghostprotocols.net, netdev@vger.kernel.org
Subject: [PATCH] [NET]: fix multicast list when cloning sockets
Date: Mon, 30 Jul 2007 13:04:48 -0300 [thread overview]
Message-ID: <20070730160448.GA4002@redhat.com> (raw)
The sock_copy() function uses memcpy() to clone the socket
including the struct ip_mc_socklist *mc_list pointer.
The ip_mc_drop_socket() function is called when socket is closed
to free these objects leaving the other sockets cloned from the
same master socket with invalid pointers.
This patch sets mc_list of cloned socket to NULL.
Signed-off-by: Flavio Leitner <fleitner@redhat.com>
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
index fbe7714..8ee0f54 100644
--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -506,6 +506,8 @@ struct sock *inet_csk_clone(struct sock *sk, const struct request_sock *req,
newicsk->icsk_backoff = 0;
newicsk->icsk_probes_out = 0;
+ inet_sk(inet)->mc_list = NULL;
+
/* Deinitialize accept_queue to trap illegal accesses. */
memset(&newicsk->icsk_accept_queue, 0, sizeof(newicsk->icsk_accept_queue));
--
1.5.2.4
--
Flavio
next reply other threads:[~2007-07-30 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 16:04 Flavio Leitner [this message]
2007-07-31 2:01 ` [PATCH] [NET]: fix multicast list when cloning sockets David Miller
2007-07-31 3:00 ` Arnaldo Carvalho de Melo
2007-07-31 18:29 ` Flavio Leitner
2007-08-25 5:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070730160448.GA4002@redhat.com \
--to=fleitner@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).