From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 ) Date: Tue, 31 Jul 2007 10:32:10 +0200 Message-ID: <20070731083210.GA1797@ff.dom.local> References: <46AB8DF9.8060903@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jason.wessel@windriver.com, amitkale@linsyssoft.com To: Gabriel C Return-path: Received: from mx10.go2.pl ([193.17.41.74]:52748 "EHLO poczta.o2.pl" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752154AbXGaIWp (ORCPT ); Tue, 31 Jul 2007 04:22:45 -0400 Content-Disposition: inline In-Reply-To: <46AB8DF9.8060903@googlemail.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 28-07-2007 20:42, Gabriel C wrote: > Andrew Morton wrote: >> On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C wrote: >> >>> Hi, >>> >>> I got this compile error with a randconfig ( http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ). >>> >>> ... >>> >>> net/core/netpoll.c: In function 'netpoll_poll': >>> net/core/netpoll.c:155: error: 'struct net_device' has no member named 'poll_controller' >>> net/core/netpoll.c:159: error: 'struct net_device' has no member named 'poll_controller' >>> net/core/netpoll.c: In function 'netpoll_setup': >>> net/core/netpoll.c:670: error: 'struct net_device' has no member named 'poll_controller' >>> make[2]: *** [net/core/netpoll.o] Error 1 >>> make[1]: *** [net/core] Error 2 >>> make: *** [net] Error 2 >>> make: *** Waiting for unfinished jobs.... >>> >>> ... >>> >>> >>> I think is because KGDBOE selects just NETPOLL. >>> >> Looks like it. >> >> Select went and selected NETPOLL and NETPOLL_TRAP but things like >> CONFIG_NETDEVICES and CONFIG_NET_POLL_CONTROLLER remain unset. `select' >> remains evil. ... > I think there may be a logical issue ( again if I got it right ). > We need some ethernet card to work with kgdboe right ? but we don't have any if !NETDEVICES && !NET_ETHERNET. > > So maybe some ' depends on ... && NETDEVICES!=n && NET_ETHERNET!=n ' is needed too ? IMHO, the only logical issue here is netpoll.c mustn't use CONFIG_NET_POLL_CONTROLLER code without #ifdef if it doesn't add this dependency itself. Cheers, Jarek P.