netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Bongani Hlope <bonganilinux@mweb.co.za>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [OOPS] 2.6.23-rc1 Seems to be network related
Date: Tue, 31 Jul 2007 18:04:07 -0700	[thread overview]
Message-ID: <20070731180407.a5c3136e.akpm@linux-foundation.org> (raw)
In-Reply-To: <200708010257.48417.bonganilinux@mweb.co.za>

On Wed, 1 Aug 2007 02:57:48 +0200 Bongani Hlope <bonganilinux@mweb.co.za> wrote:

> I'm not sure if the first email went through, resending without .config 
> attachment.

It did come through, and I replied ;)

The below post-2.6.23-rc1 patch should fix it.

commit b8c1c5da1520977cb55a358f20fc09567d40cad9
Author: Andrew Morton <akpm@linux-foundation.org>
Date:   Tue Jul 24 12:02:40 2007 -0700

    slab: correctly handle __GFP_ZERO
    
    Use the correct local variable when calling into the page allocator.  Local
    `flags' can have __GFP_ZERO set, which causes us to pass __GFP_ZERO into the
    page allocator, possibly from illegal contexts.  The page allocator will later
    do prep_zero_page()->kmap_atomic(..., KM_USER0) from irq contexts and will
    then go BUG.
    
    Cc: Mike Galbraith <efault@gmx.de>
    Acked-by: Christoph Lameter <clameter@sgi.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/mm/slab.c b/mm/slab.c
index bde271c..a684778 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -2776,7 +2776,7 @@ static int cache_grow(struct kmem_cache 
 	 * 'nodeid'.
 	 */
 	if (!objp)
-		objp = kmem_getpages(cachep, flags, nodeid);
+		objp = kmem_getpages(cachep, local_flags, nodeid);
 	if (!objp)
 		goto failed;
 


  reply	other threads:[~2007-08-01  1:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01  0:57 [OOPS] 2.6.23-rc1 Seems to be network related Bongani Hlope
2007-08-01  1:04 ` Andrew Morton [this message]
2007-08-01  6:42   ` Bongani Hlope
  -- strict thread matches above, loose matches on Subject: below --
2007-07-31 23:35 Bongani Hlope
2007-07-31 23:43 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070731180407.a5c3136e.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=bonganilinux@mweb.co.za \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).