* [PATCH] prevent SSB compilation on s390 part 2 [not found] <20070731230932.a9459617.akpm@linux-foundation.org> @ 2007-08-01 9:34 ` Heiko Carstens 2007-08-01 12:24 ` John W. Linville 2007-08-01 14:43 ` Heiko Carstens 0 siblings, 2 replies; 4+ messages in thread From: Heiko Carstens @ 2007-08-01 9:34 UTC (permalink / raw) To: Andrew Morton Cc: linux-kernel, netdev, John W. Linville, Michael Buesch, Martin Schwidefsky From: Heiko Carstens <heiko.carstens@de.ibm.com> drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should prevent SSB from being selected. But appearantly it looks like this doesn't matter at all if it gets selected from somewhere else. So add an explicit depends on HAS_IOMEM to the Broadcom driver to prevent selection on s390. Cc: "John W. Linville" <linville@tuxdriver.com> Cc: Michael Buesch <mb@bu3sch.de> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> --- drivers/net/Kconfig | 1 + 1 files changed, 1 insertion(+) Index: linux-2.6.22/drivers/net/Kconfig =================================================================== --- linux-2.6.22.orig/drivers/net/Kconfig +++ linux-2.6.22/drivers/net/Kconfig @@ -1434,6 +1434,7 @@ config APRICOT config B44 tristate "Broadcom 440x/47xx ethernet support" + depends on HAS_IOMEM select SSB select MII help ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] prevent SSB compilation on s390 part 2 2007-08-01 9:34 ` [PATCH] prevent SSB compilation on s390 part 2 Heiko Carstens @ 2007-08-01 12:24 ` John W. Linville 2007-08-01 14:43 ` Heiko Carstens 1 sibling, 0 replies; 4+ messages in thread From: John W. Linville @ 2007-08-01 12:24 UTC (permalink / raw) To: Heiko Carstens Cc: Andrew Morton, linux-kernel, netdev, Michael Buesch, Martin Schwidefsky On Wed, Aug 01, 2007 at 11:34:04AM +0200, Heiko Carstens wrote: > From: Heiko Carstens <heiko.carstens@de.ibm.com> > > drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should > prevent SSB from being selected. But appearantly it looks like this > doesn't matter at all if it gets selected from somewhere else. > So add an explicit depends on HAS_IOMEM to the Broadcom driver to > prevent selection on s390. > > Cc: "John W. Linville" <linville@tuxdriver.com> > Cc: Michael Buesch <mb@bu3sch.de> > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> Note to reviewers: this is only relevant to -mm and wireless-dev at the moment, AFAIK... John -- John W. Linville linville@tuxdriver.com ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] prevent SSB compilation on s390 part 2 2007-08-01 9:34 ` [PATCH] prevent SSB compilation on s390 part 2 Heiko Carstens 2007-08-01 12:24 ` John W. Linville @ 2007-08-01 14:43 ` Heiko Carstens 2007-08-01 14:54 ` Michael Buesch 1 sibling, 1 reply; 4+ messages in thread From: Heiko Carstens @ 2007-08-01 14:43 UTC (permalink / raw) To: Andrew Morton Cc: linux-kernel, netdev, John W. Linville, Michael Buesch, Martin Schwidefsky, Jeff Garzik On Wed, Aug 01, 2007 at 11:34:04AM +0200, Heiko Carstens wrote: > From: Heiko Carstens <heiko.carstens@de.ibm.com> > > drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should > prevent SSB from being selected. But appearantly it looks like this > doesn't matter at all if it gets selected from somewhere else. > So add an explicit depends on HAS_IOMEM to the Broadcom driver to > prevent selection on s390. > > Cc: "John W. Linville" <linville@tuxdriver.com> > Cc: Michael Buesch <mb@bu3sch.de> > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> > --- > drivers/net/Kconfig | 1 + > 1 files changed, 1 insertion(+) > > Index: linux-2.6.22/drivers/net/Kconfig > =================================================================== > --- linux-2.6.22.orig/drivers/net/Kconfig > +++ linux-2.6.22/drivers/net/Kconfig > @@ -1434,6 +1434,7 @@ config APRICOT > > config B44 > tristate "Broadcom 440x/47xx ethernet support" > + depends on HAS_IOMEM > select SSB > select MII > help By the way.. wouldn't something like depends on NET_PCI or something similar more correct for this driver? Just wondering... ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] prevent SSB compilation on s390 part 2 2007-08-01 14:43 ` Heiko Carstens @ 2007-08-01 14:54 ` Michael Buesch 0 siblings, 0 replies; 4+ messages in thread From: Michael Buesch @ 2007-08-01 14:54 UTC (permalink / raw) To: Heiko Carstens Cc: Andrew Morton, linux-kernel, netdev, John W. Linville, Martin Schwidefsky, Jeff Garzik On Wednesday 01 August 2007, Heiko Carstens wrote: > On Wed, Aug 01, 2007 at 11:34:04AM +0200, Heiko Carstens wrote: > > From: Heiko Carstens <heiko.carstens@de.ibm.com> > > > > drivers/ssb/Kconfig has already a depends on HAS_IOMEM which should > > prevent SSB from being selected. But appearantly it looks like this > > doesn't matter at all if it gets selected from somewhere else. > > So add an explicit depends on HAS_IOMEM to the Broadcom driver to > > prevent selection on s390. > > > > Cc: "John W. Linville" <linville@tuxdriver.com> > > Cc: Michael Buesch <mb@bu3sch.de> > > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> > > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> > > --- > > drivers/net/Kconfig | 1 + > > 1 files changed, 1 insertion(+) > > > > Index: linux-2.6.22/drivers/net/Kconfig > > =================================================================== > > --- linux-2.6.22.orig/drivers/net/Kconfig > > +++ linux-2.6.22/drivers/net/Kconfig > > @@ -1434,6 +1434,7 @@ config APRICOT > > > > config B44 > > tristate "Broadcom 440x/47xx ethernet support" > > + depends on HAS_IOMEM > > select SSB > > select MII > > help > > By the way.. wouldn't something like depends on NET_PCI or something > similar more correct for this driver? Just wondering... > > No, B44 does not depend on PCI. It does depend on the SSB bus. (Of course the SSB PCI parts do depend on PCI) ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-08-01 14:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070731230932.a9459617.akpm@linux-foundation.org>
2007-08-01 9:34 ` [PATCH] prevent SSB compilation on s390 part 2 Heiko Carstens
2007-08-01 12:24 ` John W. Linville
2007-08-01 14:43 ` Heiko Carstens
2007-08-01 14:54 ` Michael Buesch
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).