netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: netdev@vger.kernel.org, Felix Fietkau <nbd@openwrt.org>
Subject: Re: [PATCH 1/3] SSB EXTIF timing & serial port initialization
Date: Mon, 6 Aug 2007 20:29:55 +0200	[thread overview]
Message-ID: <20070806182955.GA32465@hall.aurel32.net> (raw)
In-Reply-To: <200708062023.08046.mb@bu3sch.de>

On Mon, Aug 06, 2007 at 08:23:07PM +0200, Michael Buesch wrote:
> On Monday 06 August 2007, Aurelien Jarno wrote:
> > The patch below adds a new file drivers/ssb/driver_extif.c which
> > contains new SSB EXTIF functions to initializes the timing and the
> > serial ports.
> > 
> > Cc: Felix Fietkau <nbd@openwrt.org>
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> 
> > +#ifdef CONFIG_SSB_SERIAL
> > +static bool serial_exists(u8 *regs)
> > +{
> > +	u8 save_mcr, msr = 0;
> > +
> > +	if (regs) {
> > +		save_mcr = regs[UART_MCR];
> > +		regs[UART_MCR] = (UART_MCR_LOOP | UART_MCR_OUT2 | UART_MCR_RTS);
> > +		msr = regs[UART_MSR] & (UART_MSR_DCD | UART_MSR_RI \
>                                                                  ^^^^^
> Backslash?
> 

Oops I did too much shell scripts recently ;-) I will send a new patch.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

  reply	other threads:[~2007-08-06 18:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-06 15:04 [PATCH 1/3] SSB EXTIF timing & serial port initialization Aurelien Jarno
2007-08-06 18:23 ` Michael Buesch
2007-08-06 18:29   ` Aurelien Jarno [this message]
2007-08-06 18:55   ` [PATCH 1/3] SSB EXTIF timing & serial port initialization (v2) Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070806182955.GA32465@hall.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=mb@bu3sch.de \
    --cc=nbd@openwrt.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).