From: David Miller <davem@davemloft.net>
To: latten@austin.ibm.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] improved xfrm_audit_log() patch
Date: Tue, 07 Aug 2007 18:32:25 -0700 (PDT) [thread overview]
Message-ID: <20070807.183225.02298028.davem@davemloft.net> (raw)
In-Reply-To: <200708022056.l72KulGS019506@faith.austin.ibm.com>
From: Joy Latten <latten@austin.ibm.com>
Date: Thu, 2 Aug 2007 15:56:47 -0500
> @@ -426,10 +426,15 @@ struct xfrm_audit
> };
>
> #ifdef CONFIG_AUDITSYSCALL
> -extern void xfrm_audit_log(uid_t auid, u32 secid, int type, int result,
> - struct xfrm_policy *xp, struct xfrm_state *x);
> +extern void xfrm_audit_log(struct xfrm_audit audit_info, int result,
> + __be32 flowid, struct xfrm_policy *xp,
> + struct xfrm_state *x, char *buf);
Passing audit_info as an aggregate argument puts them into
previous argument registers, or if they are not enough it
goes either partially of wholly onto the stack, depending
upon architecture.
In fact you've made the argument register usage worse than
in your previous revision. :-/
Perhaps you meant to pass "struct xfrm_audit *" instead?
next prev parent reply other threads:[~2007-08-08 1:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-02 20:56 [PATCH] improved xfrm_audit_log() patch Joy Latten
2007-08-08 1:32 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-08-15 16:16 Joy Latten
2007-08-21 7:24 ` David Miller
2007-08-22 19:51 ` David Miller
2007-08-23 1:29 ` Joy Latten
2007-08-23 3:05 ` David Miller
2007-08-23 17:15 ` Joy Latten
2007-08-23 20:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070807.183225.02298028.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=latten@austin.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).