[PATCH] phy layer: fix phy_mii_ioctl for autonegotiation

[PATCH] phy layer: fix phy_mii_ioctl for autonegotiation

[Domen Puncer]

Fix a thinko (?) in setting phydev->autoneg.


Signed-off-by: Domen Puncer <domen.puncer@telargo.com>

---
This fixes my "mii.h -> ethtool.h advertising #defines". I'm not sure
why and how they're translated, but it does work now.
Maybe they're just ignored, since mii-tool directly reads and writes
MII registers.


 drivers/net/phy/phy.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: work-powerpc.git/drivers/net/phy/phy.c
===================================================================
--- work-powerpc.git.orig/drivers/net/phy/phy.c
+++ work-powerpc.git/drivers/net/phy/phy.c
@@ -261,7 +261,7 @@ void phy_sanitize_settings(struct phy_de
 
 	/* Sanitize settings based on PHY capabilities */
 	if ((features & SUPPORTED_Autoneg) == 0)
-		phydev->autoneg = 0;
+		phydev->autoneg = AUTONEG_DISABLE;
 
 	idx = phy_find_valid(phy_find_setting(phydev->speed, phydev->duplex),
 			features);
@@ -374,7 +374,7 @@ int phy_mii_ioctl(struct phy_device *phy
 		if (mii_data->phy_id == phydev->addr) {
 			switch(mii_data->reg_num) {
 			case MII_BMCR:
-				if (val & (BMCR_RESET|BMCR_ANENABLE))
+				if ((val & (BMCR_RESET|BMCR_ANENABLE)) == 0)
 					phydev->autoneg = AUTONEG_DISABLE;
 				else
 					phydev->autoneg = AUTONEG_ENABLE;

Re: [PATCH] phy layer: fix phy_mii_ioctl for autonegotiation

[Jeff Garzik]

Domen Puncer wrote:
> Fix a thinko (?) in setting phydev->autoneg.
> 
> 
> Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
> 
> ---
> This fixes my "mii.h -> ethtool.h advertising #defines". I'm not sure
> why and how they're translated, but it does work now.
> Maybe they're just ignored, since mii-tool directly reads and writes
> MII registers.
> 
> 
>  drivers/net/phy/phy.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

applied