netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: heiko.carstens@de.ibm.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, schwidefsky@de.ibm.com,
	wensong@linux-vs.org, horms@verge.net.au
Subject: Re: [patch] ipvs: force read of atomic_t in while loop
Date: Wed, 08 Aug 2007 03:21:31 -0700 (PDT)	[thread overview]
Message-ID: <20070808.032131.35507346.davem@davemloft.net> (raw)
In-Reply-To: <20070808093300.GA14530@osiris.boeblingen.de.ibm.com>

From: Heiko Carstens <heiko.carstens@de.ibm.com>
Date: Wed, 8 Aug 2007 11:33:00 +0200

> Just saw this while grepping for atomic_reads in a while loops.
> Maybe we should re-add the volatile to atomic_t. Not sure.

I think whatever the choice, it should be done consistently
on every architecture.

It's just asking for trouble if your arch does it differently from
every other.

  parent reply	other threads:[~2007-08-08 10:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-08  9:33 [patch] ipvs: force read of atomic_t in while loop Heiko Carstens
2007-08-08  9:45 ` Horms
2007-08-08 10:21 ` David Miller [this message]
2007-08-08 10:28   ` Heiko Carstens
2007-08-08 21:08     ` Chris Snook
2007-08-08 21:31       ` Andrew Morton
2007-08-08 22:27         ` Heiko Carstens
2007-08-08 22:38           ` Chris Snook
2007-08-09  0:15       ` Andi Kleen
2007-08-09 12:35         ` Michael Buesch
2007-08-09 12:40           ` Chris Snook
2007-08-09 12:49             ` Martin Schwidefsky
2007-08-09 13:36           ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070808.032131.35507346.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=horms@verge.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=wensong@linux-vs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).