From: Andi Kleen <andi@firstfloor.org>
To: Michael Buesch <mb@bu3sch.de>
Cc: Andi Kleen <andi@firstfloor.org>, Jeff Garzik <jeff@garzik.org>,
ggrundstrom@neteffect.com, rdreier@cisco.com,
ewg@lists.openfabrics.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/14] nes: device structures and defines
Date: Wed, 8 Aug 2007 14:55:11 +0200 [thread overview]
Message-ID: <20070808125511.GA14419@one.firstfloor.org> (raw)
In-Reply-To: <200708081350.36081.mb@bu3sch.de>
On Wed, Aug 08, 2007 at 01:50:35PM +0200, Michael Buesch wrote:
> On Wednesday 08 August 2007 14:38:10 Andi Kleen wrote:
> > Jeff Garzik <jeff@garzik.org> writes:
> > > > + val, reg_index, addr, addr+4); */
> > > > + writel(cpu_to_le32(reg_index), addr);
> > > > + writel(cpu_to_le32(val),(u8 *)addr + 4);
> > >
> > > wrong -- endian conversion macros not needed with writel()
> >
> > Are you sure? I don't think that's true. e.g. powerpc writel
> > doesn't convert endian
>
> Andi, you are wrong.
> writeX take CPU endian args.
That is what I wrote.
-Andi
next prev parent reply other threads:[~2007-08-08 12:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 0:45 [PATCH 2/14] nes: device structures and defines ggrundstrom
2007-08-08 1:13 ` Jeff Garzik
2007-08-08 12:38 ` Andi Kleen
2007-08-08 11:50 ` Michael Buesch
2007-08-08 12:55 ` Andi Kleen [this message]
2007-08-08 13:02 ` Michael Buesch
2007-08-08 13:08 ` Andi Kleen
2007-08-08 13:28 ` Michael Buesch
2007-08-08 13:38 ` Andi Kleen
2007-08-08 13:48 ` Michael Buesch
2007-08-08 13:55 ` Michael Buesch
2007-08-08 16:18 ` Roland Dreier
2007-08-08 16:25 ` Jeff Garzik
2007-08-08 16:30 ` Michael Buesch
2007-08-08 16:33 ` Jeff Garzik
2007-08-08 16:43 ` Michael Buesch
2007-08-08 16:46 ` Roland Dreier
2007-08-08 16:57 ` akepner
2007-08-08 16:59 ` Jeff Garzik
2007-08-08 17:34 ` Michael Buesch
2007-08-08 19:40 ` Jeff Garzik
2007-08-08 16:39 ` Roland Dreier
2007-08-08 16:19 ` Jeff Garzik
2007-08-08 22:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070808125511.GA14419@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ewg@lists.openfabrics.org \
--cc=ggrundstrom@neteffect.com \
--cc=jeff@garzik.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).