From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Glenn Grundstrom" <ggrundstrom@NetEffect.com>
Cc: "Jeff Garzik" <jeff@garzik.org>, <rdreier@cisco.com>,
<ewg@lists.openfabrics.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH 6/14] nes: hardware init
Date: Thu, 9 Aug 2007 11:56:44 +0100 [thread overview]
Message-ID: <20070809115644.479a872c@oldman.hamilton.local> (raw)
In-Reply-To: <5E701717F2B2ED4EA60F87C8AA57B7CC07443E4D@venom2>
More comments
>---
>diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_hw.c
>--- NULL 1969-12-31 18:00:00.000000000 -0600
>+++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_hw.c 2007-08-06 20:09:04.000000000 -0500
>+
>+#include "nes.h"
>+u32 crit_err_count = 0;
Possible global namespace conflict. You should make sure all global
symbols start with something specfic to driver like "nes_".
>+#include "nes_cm.h"
>+
>+
>+#ifdef NES_DEBUG
>+static unsigned char *nes_iwarp_state_str[] = {
Why use unsigned char? This should be "static const char *"
Maybe use gcc array initilaizers.
prev parent reply other threads:[~2007-08-09 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 1:05 [PATCH 6/14] nes: hardware init ggrundstrom
2007-08-08 1:58 ` Jeff Garzik
2007-08-08 14:33 ` Glenn Grundstrom
2007-08-09 10:56 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070809115644.479a872c@oldman.hamilton.local \
--to=shemminger@linux-foundation.org \
--cc=ewg@lists.openfabrics.org \
--cc=ggrundstrom@NetEffect.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).