netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: ebiederm@xmission.com, linux-kernel@vger.kernel.org,
	devel@openvz.org, adobriyan@sw.ru, netdev@vger.kernel.org,
	davem@davemloft.net
Subject: Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.
Date: Thu, 9 Aug 2007 18:55:21 -0700	[thread overview]
Message-ID: <20070809185521.c3ab1afd.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070810.104710.28739250.yoshfuji@linux-ipv6.org>

On Fri, 10 Aug 2007 10:47:10 +0900 (JST) YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org> wrote:

> Hello.
> 
> In article <m1zm108axi.fsf_-_@ebiederm.dsl.xmission.com> (at Thu, 09 Aug 2007 18:56:09 -0600), ebiederm@xmission.com (Eric W. Biederman) says:
> 
> > 
> > - In ipv6 ndisc_ifinfo_syctl_change so it doesn't depend on binary
> >   sysctl names for a function that works with proc.
> > 
> > - In neighbour.c reorder the table to put the possibly unused entries
> >   at the end so we can remove them by terminating the table early.
> > 
> > - In neighbour.c kill the entries with questionable binary sysctl
> >   handling behavior.
> > 
> > - In neighbour.c if we don't have a strategy routine remove the
> >   binary path.  So we don't the default sysctl strategy routine
> >   on data that is not ready for it.
> > 
> 
> I disagree.  It is bad to remove existing interface.

But it is good to remove bad interfaces, if we possibly can.

It is worth making the attempt.  Does anyone know of anything which will
break?  I fed NET_NEIGH_ANYCAST_DELAY at random into
http://www.google.com/codesearch and came up with nothing...



  parent reply	other threads:[~2007-08-10  1:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070726164518.GB16937@localhost.sw.ru>
     [not found] ` <m13azbulhf.fsf@ebiederm.dsl.xmission.com>
     [not found]   ` <20070727145235.GC6924@localhost.sw.ru>
     [not found]     ` <20070806124530.GD6634@localhost.sw.ru>
     [not found]       ` <m1tzr8a3ms.fsf_-_@ebiederm.dsl.xmission.com>
     [not found]         ` <m1ps1wa3kf.fsf_-_@ebiederm.dsl.xmission.com>
     [not found]           ` <m1hcn8a2rq.fsf_-_@ebiederm.dsl.xmission.com>
     [not found]             ` <m1d4xw9psl.fsf_-_@ebiederm.dsl.xmission.com>
     [not found]               ` <m18x8k9ppv.fsf_-_@ebiederm.dsl.xmission.com>
     [not found]                 ` <m14pj89pmt.fsf_-_@ebiederm.dsl.xmission.com>
2007-08-10  0:56                   ` [PATCH 04/10] sysctl: Fix neighbour table sysctls Eric W. Biederman
2007-08-10  0:57                     ` [PATCH 05/10] sysctl: ipv6 route flushing (kill binary path) Eric W. Biederman
2007-08-10  0:58                       ` [PATCH 06/10] sysctl: Remove broken sunrpc debug binary sysctls Eric W. Biederman
     [not found]                         ` <m1myx08arh.fsf_-_@ebiederm.dsl.xmission.com>
     [not found]                           ` <m1ir7o8ap1.fsf_-_@ebiederm.dsl.xmission.com>
2007-08-10  1:02                             ` [PATCH 09/10] sysctl: ipv4 remove binary sysctl paths where they are broken Eric W. Biederman
2007-08-10  1:04                       ` [PATCH 06/10] sysctl: Remove broken sunrpc debug binary sysctls Eric W. Biederman
2007-08-10  1:47                     ` [PATCH 04/10] sysctl: Fix neighbour table sysctls YOSHIFUJI Hideaki / 吉藤英明
2007-08-10  1:49                       ` David Miller
2007-08-10  2:14                         ` YOSHIFUJI Hideaki / 吉藤英明
2007-08-10  2:23                           ` Eric W. Biederman
2007-08-10  2:29                             ` YOSHIFUJI Hideaki / 吉藤英明
2007-08-10  2:35                               ` Eric W. Biederman
2007-08-10  1:55                       ` Andrew Morton [this message]
2007-08-10  2:12                         ` Eric W. Biederman
2007-08-10  2:22                     ` YOSHIFUJI Hideaki / 吉藤英明

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070809185521.c3ab1afd.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=adobriyan@sw.ru \
    --cc=davem@davemloft.net \
    --cc=devel@openvz.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).