netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jeff@garzik.org
Cc: auke-jan.h.kok@intel.com, netdev@vger.kernel.org, ossthema@de.ibm.com
Subject: Re: [PATCH] [NET] ethtool: Add LRO support
Date: Fri, 10 Aug 2007 02:28:42 -0700 (PDT)	[thread overview]
Message-ID: <20070810.022842.85409561.davem@davemloft.net> (raw)
In-Reply-To: <46BC2504.9010400@garzik.org>

From: Jeff Garzik <jeff@garzik.org>
Date: Fri, 10 Aug 2007 04:42:44 -0400

> I'll code this up, along with the associated generic helpers 
> (net/core/ethtool.c), if there are no objections.

No objections except I would give the driver private it's
own set of flags.

Otherwise the number of bits you choose is arbitrary and
the potential for mistakes is definitely there is you mix
the two uses.

  reply	other threads:[~2007-08-10  9:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-09 16:41 [PATCH] [NET] ethtool: Add LRO support Auke Kok
2007-08-09 22:00 ` David Miller
2007-08-10  7:47   ` Jan-Bernd Themann
2007-08-10  8:42 ` Jeff Garzik
2007-08-10  9:28   ` David Miller [this message]
2007-08-10  9:32     ` Jeff Garzik
2007-08-10 16:24   ` Kok, Auke
  -- strict thread matches above, loose matches on Subject: below --
2007-07-31 20:21 Auke Kok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070810.022842.85409561.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=auke-jan.h.kok@intel.com \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    --cc=ossthema@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).