From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: netdev@vger.kernel.org, nhorman@tuxdriver.com,
lksctp-developers@lists.sourceforge.net
Subject: Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code
Date: Fri, 10 Aug 2007 15:06:25 -0700 (PDT) [thread overview]
Message-ID: <20070810.150625.105430969.davem@davemloft.net> (raw)
In-Reply-To: <46BCCE8B.2050605@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Fri, 10 Aug 2007 16:46:03 -0400
> This patch introduces autotuning to the sctp buffer management code
> similar to the TCP. The buffer space can be grown if the advertised
> receive window still has room. This might happen if small message
> sizes are used, which is common in telecom environmens.
> New tunables are introduced that provide limits to buffer growth
> and memory pressure is entered if to much buffer spaces is used.
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Applied, thanks Vlad.
Can you in the future fix up whitespace issues like this:
Adds trailing whitespace.
diff:21:
Space in indent is followed by a tab.
diff:27: int amt;
Space in indent is followed by a tab.
diff:48: amt = asoc->base.sk->sk_sndbuf - amt;
Space in indent is followed by a tab.
diff:55: return amt;
I know where the "Space in indent" cases come from, you apply the
patch to merge it into a current tree, you get rejects, then you edit
in the foo.rej hunks by hand into the code but forget to remove the
extra leading whitespace characters.
:-)
next prev parent reply other threads:[~2007-08-10 22:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 20:46 [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code Vlad Yasevich
2007-08-10 22:06 ` David Miller [this message]
2007-08-10 23:01 ` Neil Horman
2007-08-10 23:37 ` David Miller
2007-08-11 0:35 ` Neil Horman
2007-08-13 13:24 ` Vlad Yasevich
2007-08-13 13:49 ` Neil Horman
2007-08-15 23:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070810.150625.105430969.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lksctp-developers@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).