From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, satyam@infradead.org,
k-keiichi@bx.jp.nec.com, mpm@selenic.com
Subject: Re: [patch 25/28] netconsole: Support multiple logging targets
Date: Fri, 10 Aug 2007 15:33:51 -0700 (PDT) [thread overview]
Message-ID: <20070810.153351.21236141.davem@davemloft.net> (raw)
In-Reply-To: <200708102112.l7ALC8VN009454@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:07 -0700
> From: Satyam Sharma <satyam@infradead.org>
>
> Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.
>
> This patch introduces support for multiple targets, independent of
> CONFIG_NETCONSOLE_DYNAMIC -- this is useful even in the default case and
> (including the infrastructure introduced in previous patches) doesn't really
> add too many bytes to module text. All the complexity (and size) comes with
> the dynamic reconfigurability / userspace interface patch, and so it's
> plausible users may want to keep this enabled but that disabled (say to avoid
> a dependency on CONFIG_CONFIGFS_FS too).
>
> Also update documentation to mention the use of ";" separator to specify
> multiple logging targets in the boot/module option string.
>
> Brief overview:
>
> We maintain a target_list (and corresponding lock). Get rid of the static
> "default_target" and introduce allocation and release functions for our
> netconsole_target objects (but keeping sure to preserve previous behaviour
> such as default values). During init_netconsole(), ";" is used as the
> separator to identify multiple target specifications in the boot/module option
> string. The target specifications are parsed and netpolls setup. During
> exit, the target_list is torn down and all items released.
>
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> Signed-off-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> Cc: Matt Mackall <mpm@selenic.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-2.6.24, thanks!
prev parent reply other threads:[~2007-08-10 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 21:12 [patch 25/28] netconsole: Support multiple logging targets akpm
2007-08-10 22:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070810.153351.21236141.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=k-keiichi@bx.jp.nec.com \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=satyam@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox