From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, satyam@infradead.org
Subject: Re: [patch 27/28] Introduce U16_MAX and U32_MAX
Date: Fri, 10 Aug 2007 15:38:19 -0700 (PDT) [thread overview]
Message-ID: <20070810.153819.76325424.davem@davemloft.net> (raw)
In-Reply-To: <200708102112.l7ALCA2M009460@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 10 Aug 2007 14:12:10 -0700
> From: Satyam Sharma <satyam@infradead.org>
>
> ... in kernel.h and clean up home-grown macros elsewhere in the tree.
>
> Leave out the one in reiserfs_fs.h as it is in the userspace-visible part
> of that header. Still, #undef the (equivalent) kernel version there to
> avoid seeing "redefined, previous definition was here" gcc warnings.
>
> [akpm@linux-foundation.org: fix U16_MAX, U32_MAX defns]
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
I won't apply this one, for two reasons:
1) The reiserfs definition is better, it is _type_ based.
Please use (~(__u16)0) and (~(__u32)0), respectively.
2) The reiserfs definition is going to define an equivalent
value, so just adding an #undef and still letting reiserfs
override is wrong. Why put a common define in kernel.h
if other headers still keep their own crufty copy too?
next prev parent reply other threads:[~2007-08-10 22:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 21:12 [patch 27/28] Introduce U16_MAX and U32_MAX akpm
2007-08-10 22:38 ` David Miller [this message]
2007-08-10 23:41 ` Andrew Morton
2007-08-13 15:29 ` Satyam Sharma
2007-08-13 19:03 ` Satyam Sharma
2007-08-13 20:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070810.153819.76325424.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=satyam@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox