From: Andrew Morton <akpm@linux-foundation.org>
To: "Logix -" <thelogix@gmail.com>
Cc: "Benjamin LaHaise" <bcrl@kvack.org>,
jeff@garzik.org, netdev@vger.kernel.org, dan@scannet.dk,
jgarzik@pobox.com
Subject: Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation
Date: Fri, 10 Aug 2007 16:45:13 -0700 [thread overview]
Message-ID: <20070810164513.3d0b4e24.akpm@linux-foundation.org> (raw)
In-Reply-To: <506359130708101552n5023c81dvdb314bec26e70925@mail.gmail.com>
On Sat, 11 Aug 2007 00:52:38 +0200
"Logix -" <thelogix@gmail.com> wrote:
> On 8/11/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > > > [akpm: this is a previously-nacked patch, but the problem is real]
> >
> > I think I'll drop the whole patch. I've been nursing the thing along for
> > 1.5 years and I don't recall seeing any reports of any bugs which it would
> > have fixed anyway.
> >
>
> Except, using this card for sniffing using a passive fiber-tap cant be done,
> since with autoneg enabled, the card is set on half-duplex. Might not be a
> bug, but definitely a problem for me. But if im the only one in the world
> who needs this, so be it.
>
Feel free to send a new patch. It could be based on this one, but please
review the comments which people have had when this patch was sent on
earlier occasions.
http://marc.info/?l=linux-netdev&w=2&r=1&s=add+paramter+to+disable+autonegotiation&q=b is a decent start.
Thanks.
next prev parent reply other threads:[~2007-08-10 23:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 21:05 [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation akpm
2007-08-10 21:13 ` Benjamin LaHaise
2007-08-10 22:18 ` Andrew Morton
[not found] ` <506359130708101552n5023c81dvdb314bec26e70925@mail.gmail.com>
2007-08-10 23:45 ` Andrew Morton [this message]
2007-08-14 5:25 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070810164513.3d0b4e24.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=dan@scannet.dk \
--cc=jeff@garzik.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=thelogix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).