[patch 04/18] via-rhine: disable rx_copybreak on archs that don't allow unaligned DMA access

[patch 04/18] via-rhine: disable rx_copybreak on archs that don't allow unaligned DMA access

[akpm]

From: Dustin Marquess <jailbird@alcatraz.fdf.net>

Patch to disable the rx_copybreak feature on hardware architectures that
don't allow unaligned DMA access.

#ifdef code taken from tulip_core.c.  Problem pointed out by Ivan
Kokshaysky.

Signed-off-by: Dustin Marquess <jailbird@alcatraz.fdf.net>
Cc: Francois Romieu <romieu@fr.zoreil.com>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/net/via-rhine.c |    6 ++++++
 1 files changed, 6 insertions(+)

diff -puN drivers/net/via-rhine.c~via-rhine-disable-rx_copybreak-on-archs-that drivers/net/via-rhine.c
--- a/drivers/net/via-rhine.c~via-rhine-disable-rx_copybreak-on-archs-that
+++ a/drivers/net/via-rhine.c
@@ -42,7 +42,13 @@ static int max_interrupt_work = 20;
 
 /* Set the copy breakpoint for the copy-only-tiny-frames scheme.
    Setting to > 1518 effectively disables this feature. */
+#if defined(__alpha__) || defined(__arm__) || defined(__hppa__) \
+       || defined(CONFIG_SPARC) || defined(__ia64__) \
+       || defined(__sh__) || defined(__mips__)
+static int rx_copybreak = 1518;
+#else
 static int rx_copybreak;
+#endif
 
 /* Work-around for broken BIOSes: they are unable to get the chip back out of
    power state D3 so PXE booting fails. bootparam(7): via-rhine.avoid_D3=1 */
_

Re: [patch 04/18] via-rhine: disable rx_copybreak on archs that don't allow unaligned DMA access

[Francois Romieu]

akpm@linux-foundation.org <akpm@linux-foundation.org> :
> From: Dustin Marquess <jailbird@alcatraz.fdf.net>
> 
> Patch to disable the rx_copybreak feature on hardware architectures that
> don't allow unaligned DMA access.
> 
> #ifdef code taken from tulip_core.c.  Problem pointed out by Ivan
> Kokshaysky.

Color me confused but what are we trying to solve here ?

The rx_copybreak processing is performed after the DMA from the network
card to memory is done: DMA does not care about rx_copybreak. 

-- 
Ueimor

Re: [patch 04/18] via-rhine: disable rx_copybreak on archs that don't allow unaligned DMA access

[Jeff Garzik]

akpm@linux-foundation.org wrote:
> From: Dustin Marquess <jailbird@alcatraz.fdf.net>
> 
> Patch to disable the rx_copybreak feature on hardware architectures that
> don't allow unaligned DMA access.
> 
> #ifdef code taken from tulip_core.c.  Problem pointed out by Ivan
> Kokshaysky.
> 
> Signed-off-by: Dustin Marquess <jailbird@alcatraz.fdf.net>
> Cc: Francois Romieu <romieu@fr.zoreil.com>
> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/net/via-rhine.c |    6 ++++++
>  1 files changed, 6 insertions(+)

applied