* [patch 13/18] natsemi: fix netdev error acounting
@ 2007-08-10 21:05 akpm
2007-08-14 5:36 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2007-08-10 21:05 UTC (permalink / raw)
To: jeff; +Cc: netdev, akpm, loveminix, protasnb, thockin
From: Andrew Morton <akpm@linux-foundation.org>
When a detailed netdev error is counted, we also must account for it in the
aggregated error count.
Addresses http://bugzilla.kernel.org/show_bug.cgi?id=8106
Cc: Tim Hockin <thockin@hockin.org>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: Chongfeng Hu <loveminix@yahoo.com.cn>
Cc: Natalie Protasevich <protasnb@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/net/natsemi.c | 3 +++
1 files changed, 3 insertions(+)
diff -puN drivers/net/natsemi.c~natsemi-fix-netdev-error-acounting drivers/net/natsemi.c
--- a/drivers/net/natsemi.c~natsemi-fix-netdev-error-acounting
+++ a/drivers/net/natsemi.c
@@ -2438,13 +2438,16 @@ static void netdev_error(struct net_devi
dev->name);
}
np->stats.rx_fifo_errors++;
+ np->stats.rx_errors++;
}
/* Hmmmmm, it's not clear how to recover from PCI faults. */
if (intr_status & IntrPCIErr) {
printk(KERN_NOTICE "%s: PCI error %#08x\n", dev->name,
intr_status & IntrPCIErr);
np->stats.tx_fifo_errors++;
+ np->stats.tx_errors++;
np->stats.rx_fifo_errors++;
+ np->stats.rx_errors++;
}
spin_unlock(&np->lock);
}
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 13/18] natsemi: fix netdev error acounting
2007-08-10 21:05 [patch 13/18] natsemi: fix netdev error acounting akpm
@ 2007-08-14 5:36 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-08-14 5:36 UTC (permalink / raw)
To: akpm; +Cc: netdev, loveminix, protasnb, thockin
akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
>
> When a detailed netdev error is counted, we also must account for it in the
> aggregated error count.
>
> Addresses http://bugzilla.kernel.org/show_bug.cgi?id=8106
>
> Cc: Tim Hockin <thockin@hockin.org>
> Cc: Jeff Garzik <jeff@garzik.org>
> Cc: Chongfeng Hu <loveminix@yahoo.com.cn>
> Cc: Natalie Protasevich <protasnb@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-14 5:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-10 21:05 [patch 13/18] natsemi: fix netdev error acounting akpm
2007-08-14 5:36 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).