From: Benjamin LaHaise <bcrl@kvack.org>
To: akpm@linux-foundation.org
Cc: jeff@garzik.org, netdev@vger.kernel.org, dan@scannet.dk,
dan@hacker.dk, jgarzik@pobox.com
Subject: Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation
Date: Fri, 10 Aug 2007 17:13:49 -0400 [thread overview]
Message-ID: <20070810211349.GD978@kvack.org> (raw)
In-Reply-To: <200708102105.l7AL5ERH008951@imap1.linux-foundation.org>
On Fri, Aug 10, 2007 at 02:05:13PM -0700, akpm@linux-foundation.org wrote:
> Also added a "disable_autoneg" module argument to completely disable
> autoneg on all cards using this driver.
...
> [akpm: this is a previously-nacked patch, but the problem is real]
Please remove this part of the patch. The ethtool support is sufficient and
doesn't clobber other cards in the system. At the very least the module
parameter has to be limited to a specific card.
-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <zyntrop@kvack.org>.
next prev parent reply other threads:[~2007-08-10 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 21:05 [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation akpm
2007-08-10 21:13 ` Benjamin LaHaise [this message]
2007-08-10 22:18 ` Andrew Morton
[not found] ` <506359130708101552n5023c81dvdb314bec26e70925@mail.gmail.com>
2007-08-10 23:45 ` Andrew Morton
2007-08-14 5:25 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070810211349.GD978@kvack.org \
--to=bcrl@kvack.org \
--cc=akpm@linux-foundation.org \
--cc=dan@hacker.dk \
--cc=dan@scannet.dk \
--cc=jeff@garzik.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).